Commit Graph

34616 Commits

Author SHA1 Message Date
Reino Muhl
42bde36d16
Merge pull request #19836 from mozilla/pull-legal-docs
Some checks failed
CodeQL / Analyze (javascript) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Has been cancelled
Glean probe-scraper / glean-probe-scraper (push) Has been cancelled
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Has been cancelled
chore(docs): Latest legal PDFs
2025-12-26 15:32:28 -05:00
Pdf Bot
85bd27da59
chore(docs): Latest legal PDFs 2025-12-26 13:43:30 -05:00
Lauren Zugai
cf8ebaf80a
Merge pull request #19837 from mozilla/SYNC-5128
Some checks failed
CodeQL / Analyze (javascript) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Has been cancelled
Glean probe-scraper / glean-probe-scraper (push) Has been cancelled
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Has been cancelled
fix(session): Update GQL session.isValid to not check that the session is also verified
2025-12-23 17:37:13 -06:00
Lauren Zugai
fc93ae16f0
fix(session): Update GQL session.isValid to not check that the session is also verified
Because:
* We create a new session token on password entry, and when the user is signed into the browser without a password but not into Sync, signing into Sync will create a new session token that we do not want overwritten by the requestSignedInUser request

This commit:
* Tweaks the session.isValidToken call to only check for the session token's existence and not if it's fully verified as well

fixes FXA-12821
2025-12-23 16:56:46 -06:00
Lauren Zugai
31fbbcbf37
Merge pull request #19835 from mozilla/adjust-default-rate-limit-rules
Some checks failed
CodeQL / Analyze (javascript) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Has been cancelled
Glean probe-scraper / glean-probe-scraper (push) Has been cancelled
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Has been cancelled
Pull legal-docs / pull-legal-docs (push) Has been cancelled
chore(fxa): Adjust rate limit rules for stage
2025-12-22 12:27:21 -06:00
Lauren Zugai
23a0471be1
Merge pull request #19834 from mozilla/FXA-12809
fix(auth): Update keys check params in 2fa flow, block render on password status on SetPassword
2025-12-22 11:58:22 -06:00
Lauren Zugai
b73ce10f5e
chore(fxa): Adjust rate limit rules for stage
Because:
* We want to bring some prod values over to stage

This commit:
* Adjusts the default rate limiting for passwordForgotSendOtp
2025-12-22 11:53:27 -06:00
Vijay Budhram
74a241cda4
Merge pull request #19830 from mozilla/fxa-12795
fix(auth): Use `isSignInWithThirdPartyAuth` in SigninRecoveryPhone
2025-12-22 10:53:39 -05:00
Valerie Pomerleau
b420bcf2dd
Merge pull request #19832 from mozilla/FXA-12789
Some checks failed
CodeQL / Analyze (javascript) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Has been cancelled
Glean probe-scraper / glean-probe-scraper (push) Has been cancelled
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Has been cancelled
Auto-close stale pull requests / stale (push) Has been cancelled
fix(settings): Don't show recoverky key promo if no password set
2025-12-19 15:06:32 -08:00
Lauren Zugai
62e77432dc
fix(auth): Update keys check params in 2fa flow, block render on password status on SetPassword
Because:
* Signing into the third party auth browser flow with 2FA and a recovery code results in an error
* Users with a password already set see a flash of the SetPassword page before redirect to /signin

This commit:
* Passes the signin state into the recovery code page keys check so it skips for third party auth
* Blocks the render for SetPassword on password check, so users with a password get redirected before seeing the page render

fixes FXA-12809
fixes FXA-12811
2025-12-19 16:36:19 -06:00
Julian Poyourow
4f1f1737f9
Merge pull request #19831 from mozilla/close-adrs
chore: mark accepted ADRs as accepted
2025-12-19 12:18:39 -08:00
Valerie Pomerleau
7c0210c119
fix(settings): Don't show recoverky key promo if no password set
Because:

* Recovery key can't be created without a password

This commit:

* Adds a hasPassword check

Closes #FXA-12789
2025-12-19 12:06:10 -08:00
Julian Poyourow
7f33086261
chore: mark accepted ADRs as accepted 2025-12-19 12:01:52 -08:00
Vijay Budhram
df24ccbb45
fix(auth): Use isSignInWithThirdPartyAuth in SigninRecoveryPhone 2025-12-19 14:53:48 -05:00
Mingyuan Zhao
8646e8be24
Merge pull request #19812 from mozilla/FXA-9013
chore(settings): remove sendFxAStatusOnSettings feature flag
2025-12-19 14:01:44 -05:00
MagentaManifold
bd42d6924b
chore(settings): remove sendFxAStatusOnSettings feature flag
Because:

* the sendFxAStatusOnSettings feature flag is no longer needed

This commit:

* removes the sendFxAStatusOnSettings feature flag and code referencing it

Closes FXA-9013
2025-12-19 13:02:38 -05:00
Liza Ilina
14a6d4f532
Merge pull request #19809 from mozilla/PAY-3423-500-server-error-pm-manage
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
CodeQL / Analyze (python) (push) Waiting to run
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Waiting to run
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Blocked by required conditions
Glean probe-scraper / glean-probe-scraper (push) Waiting to run
fix(payments-next): 500 Server Error and a Server Components render error when trying to set an expired Link card as a default payment method
2025-12-19 11:43:59 -05:00
elizabeth-ilina
0d5892cfe7
fix(payments-next): 500 Server Error and a Server Components render error when trying to set an expired Link card as a default payment method
Because:

* still thinking about it

This commit:

*

Closes #PAY-3423
2025-12-19 11:27:20 -05:00
Julian Poyourow
c7371cd074
Merge pull request #19783 from mozilla/updates-to-scripts
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
CodeQL / Analyze (python) (push) Waiting to run
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Waiting to run
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Blocked by required conditions
Glean probe-scraper / glean-probe-scraper (push) Waiting to run
feat: improve customer mover and cancellation scripts
2025-12-18 22:13:02 -08:00
Dan Schomburg
7de3b2f767
Merge pull request #19822 from mozilla/FXA-12808
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
CodeQL / Analyze (python) (push) Waiting to run
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Waiting to run
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Blocked by required conditions
Glean probe-scraper / glean-probe-scraper (push) Waiting to run
task(auth-bounce-handler): Add fallback for unknown bounce types
2025-12-18 17:28:36 -08:00
dschom
3149c3982f
task(auth-bounce-handler): Add fallback for unknown bounce types
Because:
- We have examples where messages did not contain a bounce type.
- This is still a valid bounce

This Commit:
- Falls back to _fxa_unmapped in this scenaro.
2025-12-18 16:42:34 -08:00
julianpoyourow
1196233e58
feat: improve customer mover and cancellation scripts 2025-12-18 19:05:34 +00:00
Mingyuan Zhao
866e34d928
Merge pull request #19815 from mozilla/dependabot/github_actions/actions/upload-artifact-6
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
CodeQL / Analyze (python) (push) Waiting to run
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Waiting to run
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Blocked by required conditions
Glean probe-scraper / glean-probe-scraper (push) Waiting to run
chore(deps): bump actions/upload-artifact from 4 to 6
2025-12-18 10:13:14 -05:00
Mingyuan Zhao
a207f658fa
Merge pull request #19814 from mozilla/dependabot/github_actions/actions/download-artifact-7
chore(deps): bump actions/download-artifact from 4 to 7
2025-12-18 10:09:36 -05:00
dependabot[bot]
92ef528d0a
chore(deps): bump actions/upload-artifact from 4 to 6
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v4...v6)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-12-18 06:08:01 +00:00
dependabot[bot]
8239c8a3bc
chore(deps): bump actions/download-artifact from 4 to 7
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v4...v7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-12-18 06:07:58 +00:00
Amri Toufali
ac34e973c0
Merge pull request #19735 from mozilla/upgrade-to-nodemailer7
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
CodeQL / Analyze (python) (push) Waiting to run
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Waiting to run
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Blocked by required conditions
Glean probe-scraper / glean-probe-scraper (push) Waiting to run
chore(): upgrade to nodemailer 7
2025-12-17 14:08:10 -08:00
Valerie Pomerleau
eafa9e7297
Merge pull request #19768 from mozilla/FXA-12756
fix(settings): Handle null Apollo cache reads safely
2025-12-17 12:03:44 -08:00
Dan Schomburg
247fcadff8
Merge pull request #19731 from mozilla/FXA-12613
task(email-renderer): Add types to email template partials
2025-12-17 11:59:42 -08:00
dschom
9b3fe1603d
task(email-renderer): Add types to email template partials 2025-12-17 11:49:39 -08:00
Valerie Pomerleau
151ca9b4e5
Merge pull request #19744 from mozilla/FXA-12740
feat(settings): Enable split layout option on more pages
2025-12-17 11:08:19 -08:00
Valerie Pomerleau
99de368c3b
fix(settings): Handle null Apollo cache reads safely
Because:

* Sentry reports type errors when GQL cache reads return null

This commit:

* Updates Apollo readQuery usage to handle null results safely
* Tightens Typescript typing for cache reads to avoid destructuring null
* Switches from `cache.readQuery` to `client.readQuery` for safer, supported cache access
* Removes unused getProfileInfo getter

Closes #FXA-12756
2025-12-17 11:06:48 -08:00
Lauren Zugai
d70ce02b7a
Merge pull request #19811 from mozilla/quick-ai-window-fix
fix(service): Add AiWindow to isFirefoxService
2025-12-17 13:05:45 -06:00
Amri Toufali
2983fe3752
chore(): upgrade to nodemailer 7 2025-12-17 11:05:27 -08:00
Amri Toufali
1d727ad2e4
Merge pull request #19810 from mozilla/device-login-email-premature
fix(auth): device login email sent at same time as verify login email
2025-12-17 11:02:01 -08:00
Lauren Zugai
9d92852cbe
fix(service): Add AiWindow to isFirefoxService
Because:
* We aren't checking for AiWindow in this helper which is referenced when sending 'service' up to auth-server

This commit:
* Adds 'AiWindow' to isFirefoxService
2025-12-17 12:35:55 -06:00
Valerie Pomerleau
f2bcc71323
feat(settings): Enable split layout option on more pages
Because:

* The split layout option was only rendering on the index page, and we want to enable it for all pages that support customization

This commit:

* Pass the split layout property to all cms-enabled pages
* Add split layout stories for all these pages
* Update the mock cms colour scheme to Kit branding, just for funsies + update snapshots
* Add state to track split layout use for navigation (loading correct spinner)
* Small fix for the locale toggle in split layout + add focus outline

Closes #FXA-12740
2025-12-17 10:34:36 -08:00
Nick Shirley
b1d27cc29b
Merge pull request #19798 from mozilla/FXA-12591
feat(libs/emails): Add retry with backoff for email-sender
2025-12-17 11:28:26 -07:00
Amri Toufali
78318f3cc7
fix(auth): device login email sent at same time as verify login email 2025-12-17 10:16:47 -08:00
Nicholas Shirley
57491ce58c
feat(libs/emails): Add retry with backoff for email-sender
Because:
 - We want to enable retrying an email send if the send fails

This Commit:
 - Adds a new retryWithBackoff for accounts-email-sender
 - Adds configuration to change maxRetries, backoffMs, and
   ignoreTempaltes
 - Adds tests for new functionality

Closes: FXA-12591
2025-12-17 11:03:16 -07:00
Amri Toufali
04725eabd1
Merge pull request #19758 from mozilla/addtl-apperrors-cleanup
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
CodeQL / Analyze (python) (push) Waiting to run
Deploy Storybooks to GitHub Pages / Build Storybooks (push) Waiting to run
Deploy Storybooks to GitHub Pages / Deploy to GitHub Pages (push) Blocked by required conditions
Glean probe-scraper / glean-probe-scraper (push) Waiting to run
chore(errors): additional cleanup for AppError/OauthError code
2025-12-17 09:33:35 -08:00
Lauren Zugai
a4882ea41a
Merge pull request #19793 from mozilla/FXA-12760
fix(sync): Only send fxaStatus if UA is likely Fx, update unsupported context list
2025-12-17 11:32:40 -06:00
Mingyuan Zhao
5cb65a4ca7
Merge pull request #19756 from mozilla/FXA-12473
fix(mfa): fix UI issue with MFA modal on mobile
2025-12-17 11:15:48 -05:00
Mingyuan Zhao
8102dc2be6
Merge pull request #19780 from mozilla/FXA-12741
feat(mfa): add MFA to create_password page
2025-12-17 11:15:20 -05:00
MagentaManifold
b37a4d2a47
fix(mfa): fix UI issue with MFA modal on mobile
Because:

* The modal jumps on scroll

This commit:

* prevents the background from scrolling with overscroll-contain and makes scrolling work nicer
* adds a story for modal to test out scrolling

Closes FXA-12473
2025-12-17 10:29:47 -05:00
MagentaManifold
22ebe6f730
feat(mfa): add MFA to create_password page
Because:

* create_password page does not have MFA

This commit:

* adds MFA to create_password page

Closes FXA-12741
2025-12-17 10:20:41 -05:00
Mingyuan Zhao
e6bc18a029
Merge pull request #19804 from mozilla/FXA-12782
feat(storybook): upload storybooks to github pages
2025-12-17 09:54:53 -05:00
Dan Schomburg
d17db8b4a3
Merge pull request #19788 from mozilla/FXA-12703
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
CodeQL / Analyze (python) (push) Waiting to run
Glean probe-scraper / glean-probe-scraper (push) Waiting to run
task(admin): Support secret rotation for RPs
2025-12-16 17:50:25 -08:00
Lauren Zugai
4eedb67979
fix(sync): Only send fxaStatus if UA is likely Fx, update unsupported context list
Because:
* We have some Sentry events showing users not using Firefox but with valid Sync query params. We should not send fxaStatus in this case. Other events show some users on fx_ios_v1 context, which is unsupported

This commit:
* Moves the existing isProbablyFirefox check into a helper to reference also in the useFxaStatus hook
* Adds fx_ios_v1 to unsupported contexts

closes FXA-12760
2025-12-16 18:59:50 -06:00
MagentaManifold
4562f7ab8e
feat(storybook): upload storybooks to github pages
Because:

* we want to upload storybooks to github pages

This commit:

* sets up github actions for uploading storybooks to github pages

Closes FXA-12782
2025-12-16 15:35:19 -05:00