- Removed mutable mSampleCacheHolder from SpecCache class
- Added sampleCacheHolder as parameter to CalculateOneSpectrum for thread safety
- Updated ThreadLocalStorage to include per-thread sampleCacheHolder
- Added OpenMP support to CMakeLists.txt with find_package(OpenMP)
- All CalculateOneSpectrum calls now pass thread-local sampleCacheHolder
Co-authored-by: saintmatthieu <22740106+saintmatthieu@users.noreply.github.com>
Resolves: #9579
Convert filenames to/from utf-8
<!-- Use "x" to fill the checkboxes below like [x] -->
- [x] I signed [CLA](https://www.audacityteam.org/cla/)
- [x] The title of the pull request describes an issue it addresses
- [x] If changes are extensive, then there is a sequence of easily
reviewable commits
- [x] Each commit's message describes its purpose and effects
- [x] There are no behavior changes unnecessary for the stated purpose
of the PR
Recommended:
- [x] Each commit compiles and runs on my machine without known
undesirable changes of behavior
QA:
- [ ] Autobot test cases have been run
Resolves: [Assign the shortcut to "zoom to fit project"
](https://github.com/audacity/audacity/issues/9490)
The fix was pretty straightforward. I believe no further explanation is
required.
<!-- Use "x" to fill the checkboxes below like [x] -->
- [ ] I signed [CLA](https://www.audacityteam.org/cla/)
- [x] The title of the pull request describes an issue it addresses
- [x] If changes are extensive, then there is a sequence of easily
reviewable commits
- [x] Each commit's message describes its purpose and effects
- [x] There are no behavior changes unnecessary for the stated purpose
of the PR
Recommended:
- [x] Each commit compiles and runs on my machine without known
undesirable changes of behavior
QA:
- [ ] Autobot test cases have been run
Update:
I have to edit Audacity's CLA that I signed
Resolves: #9752https://github.com/audacity/audacity/issues/9415
During playback seekToX should trigger play so we change the modify the
position on clicking the timeline.
<!-- Use "x" to fill the checkboxes below like [x] -->
- [x] I signed [CLA](https://www.audacityteam.org/cla/)
- [x] The title of the pull request describes an issue it addresses
- [x] If changes are extensive, then there is a sequence of easily
reviewable commits
- [x] Each commit's message describes its purpose and effects
- [x] There are no behavior changes unnecessary for the stated purpose
of the PR
Recommended:
- [x] Each commit compiles and runs on my machine without known
undesirable changes of behavior
QA:
- [ ] Autobot test cases have been run
<!-- Use "x" to fill the checkboxes below like [x] -->
- [x] I signed [CLA](https://www.audacityteam.org/cla/)
- [x] The title of the pull request describes an issue it addresses
- [x] If changes are extensive, then there is a sequence of easily
reviewable commits
- [x] Each commit's message describes its purpose and effects
- [x] There are no behavior changes unnecessary for the stated purpose
of the PR
Recommended:
- [x] Each commit compiles and runs on my machine without known
undesirable changes of behavior
QA:
- [x] Please smoke-test change-pitch effect (only one platform is
sufficient)
- [ ] Autobot test cases have been run
Resolves: #9770
Spectrogram settings, at both track and global level.
<!-- Use "x" to fill the checkboxes below like [x] -->
- [ ] I signed [CLA](https://www.audacityteam.org/cla/)
- [ ] The title of the pull request describes an issue it addresses
- [ ] If changes are extensive, then there is a sequence of easily
reviewable commits
- [ ] Each commit's message describes its purpose and effects
- [ ] There are no behavior changes unnecessary for the stated purpose
of the PR
Recommended:
- [ ] Each commit compiles and runs on my machine without known
undesirable changes of behavior
### QA
Please note that keyboard navigation will be implemented in a follow-up
PR.
#### What this PR does NOT do
* Preview button is NOT (yet) working. Will be in a follow-up PR.
* Track spectrogram settings are NOT persistent upon app restart and
project re-opening (may become later)
#### What is does
- [x] Behaves otherwise like in Au3
- [x] Global spectrogram settings are persistent
- [ ] Follows the Figma designs (except for the bottom buttons in the
per-track dialog, which at the time of writing is inconsistent with Au3.
This PR aims for the Au3 buttons.)
- [ ] Autobot test cases have been run
<!-- Use "x" to fill the checkboxes below like [x] -->
- [x] I signed [CLA](https://www.audacityteam.org/cla/)
- [x] The title of the pull request describes an issue it addresses
- [x] If changes are extensive, then there is a sequence of easily
reviewable commits
- [x] Each commit's message describes its purpose and effects
- [x] There are no behavior changes unnecessary for the stated purpose
of the PR
Recommended:
- [x] Each commit compiles and runs on my machine without known
undesirable changes of behavior
QA:
Please note that this PR contains the fixes merged on alpha only:
https://github.com/audacity/audacity/pull/9710. That PR was already
tested by @dozzzzer. We are now porting these changes back to master.
On top of these changes, we here are doing some refactoring: easy
changes, but widespread. Hence the following checklist:
- [x] Please smoke-test _all_ built-in effects and generators, in
destructive and real-time mode where applicable,
- [x] Smoke-test one third-party effect of each family (VST, AudioUnit
and LV2) in destructive and real-time modes,
- [x] Presets work as expected
- [x] In realtime mode, replacing one effect by another works as
expected (UI of effect being replaced disappears, that of the new effect
appears)
- [x] Autobot test cases have been run
