Mirrors/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-28 06:31:58 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix ADMX generation to use underscores instead of . (#279406)

Browse Source
This commit is contained in:
Paul 2025-11-25 10:39:47 -08:00 committed by GitHub
parent 643ae5a998
commit 43285776cc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
build/lib/policies/stringEnumPolicy.ts
View File

@ -58,7 +58,7 @@ export class StringEnumPolicy extends BasePolicy {
protected renderADMXElements(): string[] {
return [
`<enum id="${this.name}" valueName="${this.name}">`,
...this.enum_.map((value, index) => ` <item displayName="$(string.${this.name}_${this.enumDescriptions[index].nlsKey})"><value><string>${value}</string></value></item>`),
...this.enum_.map((value, index) => ` <item displayName="$(string.${this.name}_${this.enumDescriptions[index].nlsKey.replace(/\./g, '_')})"><value><string>${value}</string></value></item>`),
`</enum>`
];
}

14
build/lib/test/fixtures/policies/win32/CodeOSS.admx vendored
View File

@ -45,9 +45,9 @@
<supportedOn ref="Supported_1_99" />
<elements>
<enum id="ChatMCP" valueName="ChatMCP">
<item displayName="$(string.ChatMCP_chat.mcp.access.none)"><value><string>none</string></value></item>
<item displayName="$(string.ChatMCP_chat.mcp.access.registry)"><value><string>registry</string></value></item>
<item displayName="$(string.ChatMCP_chat.mcp.access.any)"><value><string>all</string></value></item>
<item displayName="$(string.ChatMCP_chat_mcp_access_none)"><value><string>none</string></value></item>
<item displayName="$(string.ChatMCP_chat_mcp_access_registry)"><value><string>registry</string></value></item>
<item displayName="$(string.ChatMCP_chat_mcp_access_any)"><value><string>all</string></value></item>
</enum>
</elements>
</policy>
@ -113,10 +113,10 @@
<supportedOn ref="Supported_1_99" />
<elements>
<enum id="TelemetryLevel" valueName="TelemetryLevel">
<item displayName="$(string.TelemetryLevel_telemetry.telemetryLevel.default)"><value><string>all</string></value></item>
<item displayName="$(string.TelemetryLevel_telemetry.telemetryLevel.error)"><value><string>error</string></value></item>
<item displayName="$(string.TelemetryLevel_telemetry.telemetryLevel.crash)"><value><string>crash</string></value></item>
<item displayName="$(string.TelemetryLevel_telemetry.telemetryLevel.off)"><value><string>off</string></value></item>
<item displayName="$(string.TelemetryLevel_telemetry_telemetryLevel_default)"><value><string>all</string></value></item>
<item displayName="$(string.TelemetryLevel_telemetry_telemetryLevel_error)"><value><string>error</string></value></item>
<item displayName="$(string.TelemetryLevel_telemetry_telemetryLevel_crash)"><value><string>crash</string></value></item>
<item displayName="$(string.TelemetryLevel_telemetry_telemetryLevel_off)"><value><string>off</string></value></item>
</enum>
</elements>
</policy>

6
build/lib/test/stringEnumPolicy.test.ts
View File

@ -55,9 +55,9 @@ suite('StringEnumPolicy', () => {
'\t<supportedOn ref="Supported_1_0" />',
'\t<elements>',
'<enum id="TestStringEnumPolicy" valueName="TestStringEnumPolicy">',
'\t<item displayName="$(string.TestStringEnumPolicy_test.option.one)"><value><string>auto</string></value></item>',
'\t<item displayName="$(string.TestStringEnumPolicy_test.option.two)"><value><string>manual</string></value></item>',
'\t<item displayName="$(string.TestStringEnumPolicy_test.option.three)"><value><string>disabled</string></value></item>',
'\t<item displayName="$(string.TestStringEnumPolicy_test_option_one)"><value><string>auto</string></value></item>',
'\t<item displayName="$(string.TestStringEnumPolicy_test_option_two)"><value><string>manual</string></value></item>',
'\t<item displayName="$(string.TestStringEnumPolicy_test_option_three)"><value><string>disabled</string></value></item>',
'</enum>',
'\t</elements>',
'</policy>'