Commit Graph

95 Commits

Author SHA1 Message Date
Pablo Zmdl
202daa6f97 Replace changed by expires_at in session handling
This prepares using extended session lifetimes configurable per session
2025-12-04 14:47:16 +01:00
Michael Voříšek
026eb8c801
Enforce leading backslash for non-namespaced non-Roundcube uses (#9935) 2025-08-15 10:27:00 +02:00
Aleksander Machniak
c588b6fe81 Improve installer to fix confusion about disabling SMTP authentication (#9801) 2025-03-09 12:43:32 +01:00
Aleksander Machniak
82e5d5ce10 More CS fixes 2025-02-23 12:10:21 +01:00
Aleksander Machniak
64df318a73
Add static files server (#9294)
Make use of public_html mandatory
2025-02-09 14:10:50 +01:00
Philip Weir
ccede1f272
Update links in comments and config to https where available (#9759) 2025-01-26 13:34:57 +01:00
Ian Freeman
9183d37cfb Add 'php' log_driver, passing log entries off to php's configured
error_log facility.
2024-11-10 14:55:35 -08:00
Aleksander Machniak
5ed3b29a0a Code improvements 2024-03-16 21:30:10 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
8c83518822 Installer: Remove useless DB time diff check, fix phpstan errors 2024-01-27 16:06:09 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS (#9303)
* fix "class_attributes_separation"

* fix "ternary_to_null_coalescing"

* fix "no_extra_blank_lines"

* fix "php_unit_data_provider_name" - use snake_case

* fix remaining "function data_" manually

* move "php_unit_test_case_static_method_calls" to a better place in cnf

* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS (#9283)
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III (#9270)
* fix "single_trait_insert_per_statement"

* fix "empty_loop_condition"

* fix "backtick_to_shell_exec"

* fix "phpdoc_to_comment"

* fix "no_empty_statement"

* fix "heredoc_to_nowdoc"

* fix "class_reference_name_casing"

* fix "align_multiline_comment"

* fix "heredoc_indentation"

* fix "constant_case"

* fix "single_line_comment_style"

* fix "no_null_property_initialization"

* fix "standardize_increment"

* fix "no_unneeded_control_parentheses"

* fix missing NL after "<?php"

* fix php in *.sh files too

* fix trailing spaces from all text files

* fix "explicit_indirect_variable"

* Revert "fix "align_multiline_comment""

This reverts commit 42e584f8e3.

* fix "align_multiline_comment" properly

* Revert "fix trailing spaces from all text files" - diff files only

* Revert "Revert "fix trailing spaces from all text files" - diff files only"

This reverts commit 2101c2a3a3.

* rm useless "setup-php" config
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II (#9254)
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS (#9258)
* fix "yoda_style"

* fix "is_null"

* rm useless rule ignores

* add full "PhpCsFixer:risky" ruleset

* fix "implode_call"

* fix "no_alias_functions"

* fix "array_push"

* fix "long_to_shorthand_operator"

* fix "ternary_to_elvis_operator"

* fix "logical_operators"

* fix "fopen_flags"

* rename "returns" phpdoc tags to "return"

* fix "php_unit_construct"

* fix "function_to_constant"

* fix "php_unit_data_provider_return_type"

* fix "php_unit_set_up_tear_down_visibility"

* some safe "string_length_to_empty"

* fix "phpdoc_align"

* fix "phpdoc_no_alias_tag"

* fix "trailing_comma_in_multiline"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI (#9246)
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-16 15:37:43 +01:00
Aleksander Machniak
20447fa962 Fix PHP8 warnings (#9142) 2023-09-18 11:15:33 +02:00
Aleksander Machniak
893216cb29 Unified and simplified services connection options (#8310) 2021-12-07 15:07:54 +01:00
Josh Soref
203f456620
Spelling (#8001) 2021-04-18 08:43:18 +02:00
Aleksander Machniak
670c0a6df5 Installer: Fix non-working Initialize database and Update buttons (#7847) 2021-01-24 08:58:22 +01:00
Aleksander Machniak
75fca18da4 Use proper array key, fix some typos 2021-01-18 19:24:47 +01:00
Aleksander Machniak
3bbb01fe13 PHP8 fixes, regression fixes 2020-12-13 12:14:15 +01:00
Aleksander Machniak
12547ccf01 Require php-intl extension, get rid of Net_IDNA2, PHP8 fixes, short array syntax
Net_IDNA2 is not compatible, and Intl is a bundled ext since PHP 5.3.
Fixed some regressions.
2020-12-13 10:21:52 +01:00
Aleksander Machniak
bdeb0db6cb Small code fixes 2020-08-21 08:19:27 +02:00
Aleksander Machniak
af0e98759d Installer: Fix regression in SMTP test section (#7417) 2020-06-04 07:24:36 +02:00
Aleksander Machniak
31249d932d Security: Fix couple of XSS issues in Installer (#7406) 2020-05-30 08:05:37 +02:00
johndoh
34a0af8964
Allow array in smtp_host config (#7296) 2020-05-16 14:05:28 +02:00
Aleksander Machniak
b3b5b9665d Fix regression in testing database schema on MSSQL (#7227) 2020-03-08 11:55:46 +01:00
Aleksander Machniak
2f928a516d Fix DB Write test on SQLite database ("database is locked" error) (#7064)
Also fix so SQLite DSN with a relative path to the database file works in Installer
2019-11-24 09:37:14 +01:00
Aleksander Machniak
98c71ee62e Remove unused variables 2019-11-11 09:57:44 +01:00
Aleksander Machniak
b89031e335 Fix PHP Deprecated: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated
Use rcube_utils::idn_to_ascii() instead of idn_to_ascii().
2019-05-10 21:37:05 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
74fe74bf7d Make "0.9 or newer" a default selection for db schema update box 2019-01-30 12:55:04 +01:00
Aleksander Machniak
4d44070fc6 Fix duplicated labels in Test SMTP Config section (#6166) 2018-02-11 18:05:26 +01:00
Aleksander Machniak
a98fb374a7 Small visual improvement 2017-11-18 15:55:48 +01:00
Aleksander Machniak
1a8bdf554a Fix "DB Write" test (#5479) 2016-10-18 08:25:47 +02:00
Aleksander Machniak
ee895a2c96 Remove PHP mail() support, smtp_server is required now (#5340) 2016-07-15 15:24:45 +02:00
Aleksander Machniak
69a1e4f7b1 rcube_parse_host() -> rcube_utils::parse_host() 2015-11-25 08:52:59 +01:00
Aleksander Machniak
74ce01efc7 Q() -> rcube::Q() 2015-10-23 08:02:57 +02:00
Aleksander Machniak
df10bd5f2c Fix bug where imap_conn_options were ignored in IMAP connection test (#1490392) 2015-05-14 13:19:28 +02:00
Aleksander Machniak
34a0902089 Use consistent column/table quoting in sql queries 2014-09-12 14:37:51 +02:00
Aleksander Machniak
6b0106a324 Fix some mime-type to extension mapping checks in Installer (#1489983) 2014-07-22 19:10:42 +02:00
Aleksander Machniak
37ac40719f Fix IMAP connection test in installer so it is aware of imap_auth_type (#1489746) 2014-05-02 19:35:54 +02:00
Aleksander Machniak
90f7aa9e39 Fix varius db_prefix issues (#1489839)
- Move DDL script execution code to rcube_db class(es).
- Improve prefix replacement code, so index names are also modified
2014-04-29 11:34:43 +02:00
Thomas Bruederli
eea11ecdde Move rcube_installer class to include/rcmail_installer in order to remain accessible by the update script even if the installer directory was removed 2014-04-21 16:39:19 +02:00
Aleksander Machniak
517c9f9a8d Fix directories check in Installer on Windows (#1489576)
Added rcube_utils::is_absolute_path() method
2014-02-07 14:43:51 +01:00
Thomas Bruederli
0703bfecd0 Merged configuration refactoring from 'dev_config' branch back into master (#1487311) 2013-07-10 22:49:12 +02:00
Thomas Bruederli
8f49e4a99c Check filetype detection in installer and update script (#1489193) 2013-07-04 23:56:26 +02:00
Aleksander Machniak
461a30d771 Merge config files (#1487311).
Now we have defaults.inc.php and config.inc.php.
Renamed $rcmail_config to $config. Old naming and old files are supported
for backward compatibility.
2013-06-14 12:09:08 +02:00