Commit Graph

263 Commits

Author SHA1 Message Date
Aleksander Machniak
0675156ab2 Add dummy index.php
Some checks failed
E2E / Linux / PHP ${{ matrix.php }} (8.1) (push) Has been cancelled
E2E / Linux / PHP ${{ matrix.php }} (8.3) (push) Has been cancelled
CI / Coding Style (push) Has been cancelled
CI / Static Analysis (push) Has been cancelled
Message Rendering / Linux / PHP 8.3 (push) Has been cancelled
Unit / Linux / PHP ${{ matrix.php }} (7.3) (push) Has been cancelled
Unit / Linux / PHP ${{ matrix.php }} (7.4) (push) Has been cancelled
Unit / Linux / PHP ${{ matrix.php }} (8.0) (push) Has been cancelled
Unit / Linux / PHP ${{ matrix.php }} (8.1) (push) Has been cancelled
Unit / Linux / PHP ${{ matrix.php }} (8.2) (push) Has been cancelled
Unit / Linux / PHP ${{ matrix.php }} (8.3) (push) Has been cancelled
Unit / Windows / PHP ${{ matrix.php }} (7.3) (push) Has been cancelled
Unit / Windows / PHP ${{ matrix.php }} (7.4) (push) Has been cancelled
Unit / Windows / PHP ${{ matrix.php }} (8.0) (push) Has been cancelled
Unit / Windows / PHP ${{ matrix.php }} (8.1) (push) Has been cancelled
Unit / Windows / PHP ${{ matrix.php }} (8.2) (push) Has been cancelled
Unit / Windows / PHP ${{ matrix.php }} (8.3) (push) Has been cancelled
roundcubemail-testrunner image / build and push with PHP ${{ matrix.php }} (8.3) (push) Has been cancelled
2025-02-09 14:27:22 +01:00
Aleksander Machniak
64df318a73
Add static files server (#9294)
Make use of public_html mandatory
2025-02-09 14:10:50 +01:00
Philip Weir
ccede1f272
Update links in comments and config to https where available (#9759) 2025-01-26 13:34:57 +01:00
Michael Voříšek
a30e0ad438
Infer file/line location in rcube::raise_error() from backtrace (#9422)
* \n\s+'file' => __FILE__,

* \n\s+'line' => __LINE__,

* 'line' => __LINE__, 'file' => __FILE__,

* 'file' => __FILE__, 'line' => __LINE__,

* rest

* more

* improve cs

* more cs

* revert rcube_utils::preg_error changes

* impl file/line from backtrace

* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS (#9303)
* fix "class_attributes_separation"

* fix "ternary_to_null_coalescing"

* fix "no_extra_blank_lines"

* fix "php_unit_data_provider_name" - use snake_case

* fix remaining "function data_" manually

* move "php_unit_test_case_static_method_calls" to a better place in cnf

* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS (#9283)
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II (#9254)
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS (#9258)
* fix "yoda_style"

* fix "is_null"

* rm useless rule ignores

* add full "PhpCsFixer:risky" ruleset

* fix "implode_call"

* fix "no_alias_functions"

* fix "array_push"

* fix "long_to_shorthand_operator"

* fix "ternary_to_elvis_operator"

* fix "logical_operators"

* fix "fopen_flags"

* rename "returns" phpdoc tags to "return"

* fix "php_unit_construct"

* fix "function_to_constant"

* fix "php_unit_data_provider_return_type"

* fix "php_unit_set_up_tear_down_visibility"

* some safe "string_length_to_empty"

* fix "phpdoc_align"

* fix "phpdoc_no_alias_tag"

* fix "trailing_comma_in_multiline"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-17 09:51:11 +01:00
Edouard Vanbelle
588a879107
OAuth improvements (#9217)
- OAuth: Add `oauth_config_uri` - support OAuth/OpenIDC discovery (#8201)
- OAuth: Add `oauth_logout_uri` - allow invalidating the OAUTH-Session on logout (#8057)
- OAuth: Support for OpenID Connect RP-Initiated Logout (#9109)
- OAuth: Add support of OAUTHBEARER (#9217)
- OAuth: Add `oauth_debug` option (#9217)
- OAuth: Fix: missing config `oauth_provider_name` in rcmail_oauth's constructor (#9217)
- OAuth: Refactor: move display to the rcmail_oauth class and use `loginform_content` hook (#9217)

Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr>
Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-17 09:13:07 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI (#9246)
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-16 15:37:43 +01:00
Aleksander Machniak
a20445fcc5 Fix potential HTTP protocol version mismatch (#8982) 2023-05-07 16:37:17 +02:00
Aleksander Machniak
42f9cdceba Master is 1.7-git 2022-06-23 19:02:23 +02:00
Aleksander Machniak
f429b26810 Fix various PHP8 warnings (#8392) 2022-01-11 19:04:24 +01:00
Aleksander Machniak
eec0d2b578 Display a generic error page on initial DB/configuration errors (#8222) 2021-10-27 14:27:56 +02:00
Aleksander Machniak
6f435ecb52 Fix fatal error/warning on invalid input to user parameter (#8152)
Added a new utility method: rcube_utils::get_input_string()
2021-08-01 10:31:09 +02:00
Aleksander Machniak
b4fd75d6c1 Master is 1.6-git now 2021-07-25 09:08:20 +02:00
Aleksander Machniak
0d676625d8 Fix PHP8 warning 2021-05-21 14:56:59 +02:00
Aleksander Machniak
5ec509f87e FIX PHP8 fatal error and some warnings (#7931) 2021-03-10 18:24:18 +01:00
Aleksander Machniak
b3677c3e0b Fix oauth action run 2020-12-31 08:34:48 +01:00
johndoh
cfd4fa170f
Fix a few PHP notices (#7791) 2020-12-19 19:36:58 +01:00
Aleksander Machniak
dcfd12e98a CS fixes, potential PHP8 warning (#7781) 2020-12-18 18:17:01 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring (#7688)
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
f95212d626 PHP8: More warnings fixed 2020-10-11 15:24:30 +02:00
Thomas Bruederli
c9beef0bc2 Check if OAuth is enabled before including oauth.inc step file 2020-06-16 08:17:52 +02:00
Thomas Bruederli
1e6a2f4f49 Basic support for OAuth2 user login and IMAP/SMTP authentication
- Add "Login with XXX" button to login screen if oauth is configured
- Perform OAuth login procedure and get an access token
- Implement XOAUTH2 authentication type for IAMP and SMTP

Requires a patched and not yet released version of Net_SMTP.
2020-06-16 08:17:52 +02:00
Aleksander Machniak
8344f07d7f Fix CSRF bypass that could be used to log out an authenticated user (#7302) 2020-04-26 08:03:59 +02:00
Aleksander Machniak
b8555ce4f3 Fix so 401 error is returned only on failed logon requests (#7010) 2019-11-11 12:41:00 +01:00
Aleksander Machniak
9f1d185c44 Master is 1.5-git now 2019-10-27 09:45:15 +01:00
Aleksander Machniak
f1a83f923d Added cookie mismatch detection, display an error message informing the user to clear cookies 2019-04-19 10:12:23 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
11216a1925 Changed 'password_charset' default to 'UTF-8' (#6522) 2018-11-16 13:22:13 +01:00
Aleksander Machniak
186f21c4c1 Avoid Referer leaking by using Referrer-Policy:same-origin header (#6385)
Added 'common_headers' hook
2018-10-21 11:39:39 +02:00
Aleksander Machniak
f1ee6d7906 Plugin API: Add possibility to specify HTTP return code via 'unauthenticated' hook 2018-10-15 10:01:12 +02:00
Aleksander Machniak
e4ccc2bb48 Update copyright year in few places 2018-03-09 13:30:56 +01:00
Aleksander Machniak
fb2f213d6f Add id attribute to the installer warning 2017-12-24 08:27:22 +01:00
Aleksander Machniak
2cb9de358b Return "401 Unauthorized" status when login fails (#5663) 2017-06-26 16:53:04 +02:00
Aleksander Machniak
e51fa197bb Remove unused variable 2017-06-05 09:44:58 +02:00
Aleksander Machniak
5101cfc67a Bump version to 1.4-git 2017-05-15 11:34:43 +02:00
Thomas Bruederli
f78e2a4367 Add 1.3-beta milestone + update copyright year 2017-01-03 18:24:34 +01:00
Aleksander Machniak
ad9a55f8cb Support hostname and hostname:port in force_https option (#5511) 2016-11-20 15:27:21 +01:00
Aleksander Machniak
24b4ca52cf Fix so "Action disabled" error uses more appropriate 404 code (#5440) 2016-09-21 09:03:37 +02:00
Aleksander Machniak
b77efcd104 Fix typo 2016-06-29 09:02:59 +02:00
Aleksander Machniak
85082c88c7 CS fixes 2016-06-29 08:58:59 +02:00
Aleksander Machniak
9634169647 Bump version number to 1.3-beta 2016-05-02 14:37:39 +02:00
Aleksander Machniak
a15d877ba8 Added brute-force attack prevention via login rate limit (#1490566) 2015-11-11 18:53:43 +01:00
Aleksander Machniak
1b39d9a6c7 PHP7: Fixed some E_WARNING errors that previously were E_STRICT 2015-08-08 09:32:24 +02:00
Aleksander Machniak
4b72a1f498 Fix error when using back button after sending an email (#1490009) 2015-07-31 18:48:17 +02:00
Aleksander Machniak
a958748947 CS fixes 2015-06-07 15:26:33 +02:00