mirror of
https://github.com/nodejs/node.git
synced 2025-12-28 16:07:39 +00:00
31aacfa67c
Based on some recent confusion around the objection process for PRs, this commit adds some additional clarification to the collaborator guide. Specifically, it clarifies that: * Objections must be made in the PR itself * All objections are considered equal... no special additional weight is given to objections from TSC members. * When mistakes happen and a PR lands despite having an unresolved objection, any revert or fixup PR is subject to the same regular objection process, albeit with a callout that fast-tracking is possible if uncontroversial. PR-URL: https://github.com/nodejs/node/pull/59096 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> |
||
|---|---|---|
| .. | ||
| doc_img | ||
| maintaining | ||
| adding-new-napi-api.md | ||
| adding-v8-fast-api.md | ||
| advocacy-ambassador-program.md | ||
| api-documentation.md | ||
| backporting-to-release-lines.md | ||
| building-node-with-ninja.md | ||
| code-of-conduct.md | ||
| collaborator-guide.md | ||
| commit-queue.md | ||
| components-in-core.md | ||
| cpp-style-guide.md | ||
| diagnostic-tooling-support-tiers.md | ||
| distribution.md | ||
| erm-guidelines.md | ||
| feature-request-management.md | ||
| gn-build.md | ||
| internal-api.md | ||
| investigating-native-memory-leaks.md | ||
| issues.md | ||
| managing-social-media-acounts.md | ||
| node-postmortem-support.md | ||
| offboarding.md | ||
| primordials.md | ||
| pull-requests.md | ||
| recognizing-contributors.md | ||
| releases-node-api.md | ||
| releases.md | ||
| security-model-strategy.md | ||
| security-release-process.md | ||
| security-steward-on-off-boarding.md | ||
| sharing-project-news.md | ||
| static-analysis.md | ||
| strategic-initiatives.md | ||
| streaming-to-youtube.md | ||
| suggesting-social-media-posts.md | ||
| technical-priorities.md | ||
| technical-values.md | ||
| using-internal-errors.md | ||
| using-symbols.md | ||
| writing-and-running-benchmarks.md | ||
| writing-docs.md | ||
| writing-tests.md | ||