mirror of
https://github.com/nodejs/node.git
synced 2025-12-27 23:41:14 +00:00
Tests should be explicit regarding whether a promise is expected to settle, and the test should fail when the behavior does not meet expectations. PR-URL: https://github.com/nodejs/node/pull/60976 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
38 lines
1.1 KiB
JavaScript
38 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { startNewREPLServer } = require('../common/repl');
|
|
const assert = require('node:assert');
|
|
|
|
// This test checks that an eval function returning an error in its callback
|
|
// after the repl server has been closed doesn't cause an ERR_USE_AFTER_CLOSE
|
|
// error to be thrown (reference: https://github.com/nodejs/node/issues/58784)
|
|
|
|
(async () => {
|
|
const close$ = Promise.withResolvers();
|
|
const eval$ = Promise.withResolvers();
|
|
|
|
const { replServer, output } = startNewREPLServer({
|
|
eval(_cmd, _context, _file, cb) {
|
|
// eslint-disable-next-line node-core/must-call-assert
|
|
close$.promise.then(() => {
|
|
cb(new Error('Error returned from the eval callback'));
|
|
eval$.resolve();
|
|
});
|
|
},
|
|
}, {
|
|
disableDomainErrorAssert: true,
|
|
});
|
|
|
|
replServer.write('\n');
|
|
|
|
replServer.close();
|
|
close$.resolve();
|
|
|
|
process.on('uncaughtException', common.mustNotCall());
|
|
|
|
await eval$.promise;
|
|
|
|
assert.match(output.accumulator, /Uncaught Error: Error returned from the eval callback/);
|
|
})().then(common.mustCall());
|