Commit Graph

31 Commits

Author SHA1 Message Date
Marco Ippolito
478a2e656d
tools: add config subspace
PR-URL: https://github.com/nodejs/node/pull/57239
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
2025-03-09 16:09:33 +00:00
Joyee Cheung
e85964610c module: implement module.registerHooks()
PR-URL: https://github.com/nodejs/node/pull/55698
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
2024-12-09 23:27:08 +00:00
Aviv Keller
dc86592f20
meta: add module label for the lib/internal/modules folder
PR-URL: https://github.com/nodejs/node/pull/52858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-06 18:34:11 +00:00
Marco Ippolito
b3013e120a
tools: add strip-types to label system
PR-URL: https://github.com/nodejs/node/pull/54185
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2024-08-05 07:14:55 +00:00
Alex Yang
3779c2ccd2
meta: add sqlite to js subsystems
PR-URL: https://github.com/nodejs/node/pull/53911
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-07-27 13:35:40 +00:00
Aviv Keller
38b7ce3b1e
meta: add node_sqlite.c to PR label config
PR-URL: https://github.com/nodejs/node/pull/53797
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-07-12 20:42:49 +00:00
jakecastelli
5c3ecbee62
tools: add stream label on PR when related files being changed in lib
PR-URL: https://github.com/nodejs/node/pull/53269
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-06-07 18:52:05 +00:00
Michaël Zasso
7e6d92c485
tools: update ESLint to v9 and use flat config
Closes: https://github.com/nodejs/node/issues/52567
PR-URL: https://github.com/nodejs/node/pull/52780
Fixes: https://github.com/nodejs/node/issues/52567
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-05-23 19:45:18 +00:00
Aviv Keller
4ddacbaa82
meta: standardize regex
PR-URL: https://github.com/nodejs/node/pull/52693
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-04-29 20:30:14 +00:00
Ben Noordhuis
f73650ea52
tools: remove genv8constants.py
Unused after commit aa3a572e6b ("build: remove dtrace & etw support")
from last year. I had this vague notion that llnode also used it but
that is another script.

Fixes: https://github.com/nodejs/node/issues/49991
PR-URL: https://github.com/nodejs/node/pull/50023
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-05 21:11:10 +00:00
Shrujal Shah
c18a455542
meta: remove dont-land-on-v14 auto labeling
PR-URL: https://github.com/nodejs/node/pull/48031
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-05-18 10:31:01 +00:00
Mohammed Keyvanzadeh
1fe41a8c57
tools: update PR label config
- Update paths to the new ones.
- Remove paths that no longer exist.
- Capitalize comments and quote labels mentioned within.
- Fix syntax error in regex.
- Add missing JavaScript subsystems.

PR-URL: https://github.com/nodejs/node/pull/47593
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-04-20 16:04:31 +00:00
Yagiz Nizipli
5931b44d98 tools: add url and whatwg-url labels automatically
PR-URL: https://github.com/nodejs/node/pull/47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
2023-04-15 16:02:02 +00:00
Yagiz Nizipli
8b1c34cf22 tools: add performance label to benchmark changes
PR-URL: https://github.com/nodejs/node/pull/47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
2023-04-15 16:02:01 +00:00
Joyee Cheung
1ccc8cc858
meta: add single-executable labels and code owners
PR-URL: https://github.com/nodejs/node/pull/47004
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2023-03-10 11:47:47 +00:00
Moshe Atlow
77c0448ede
meta: remove dont-land-on-v12 auto labeling
PR-URL: https://github.com/nodejs/node/pull/45233
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-10-30 19:38:26 +00:00
Moshe Atlow
e5c807e115
meta: label test.js and test.md with test_runner label
PR-URL: https://github.com/nodejs/node/pull/44863
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-10-02 11:19:20 +00:00
Shrujal Shah
e039549d1f
meta: update test_runner in label-pr-config
PR-URL: https://github.com/nodejs/node/pull/44615
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2022-09-15 08:06:58 +00:00
Tobias Nießen
ad41c919df
src: remove v8abbr.h
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: https://github.com/nodejs/node/pull/43652
PR-URL: https://github.com/nodejs/node/pull/44402
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-08-30 12:57:22 +00:00
Daeyeon Jeong
5c923a4b06
meta: update web streams in label-pr-config
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: https://github.com/nodejs/node/pull/44235
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2022-08-17 18:36:17 +00:00
Daeyeon Jeong
72fd06f7f0
meta: update node-api in label-pr-config
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: https://github.com/nodejs/node/pull/43794
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-07-24 13:12:07 +01:00
Feng Yu
b4398df2e5
tools: refactor build-addons.js to ESM
PR-URL: https://github.com/nodejs/node/pull/43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-05-22 14:28:41 +01:00
Mestery
24487befb7
meta: add dependencies label to label-pr-config
PR-URL: https://github.com/nodejs/node/pull/42129
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-03-07 22:34:36 +00:00
Mestery
b80b85e130 meta: add typings to label-pr-config
PR-URL: https://github.com/nodejs/node/pull/40401
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
2021-10-14 11:55:09 +00:00
Mestery
eaa59571e0 meta: update label-pr-config
PR-URL: https://github.com/nodejs/node/pull/40199
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-10-09 17:11:31 +00:00
Michaël Zasso
f367af4434 tools: extend default yamllint config
PR-URL: https://github.com/nodejs/node/pull/40150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-09-21 17:03:51 +00:00
Michaël Zasso
07339eca4a
meta: update label-pr-config
- Rename "ES Modules" label to "esm" (This already happened on GitHub
  a while ago).
- Add missing "fast-track" to deps/npm (It was lost when the pull
  request adding it landed).
- Rename "intl" to "i18n-api" (There is no intl label).
- Rename "url-whatwg" to "whatwg-url".
- Rename "V8 Engine" to "v8 engine".
- Rename "n-api" to "node-api".
- Add "python" to .py files.
- Add "gyp" to tools/gyp.
- Add "icu" to tools/icu.
- Add "tools" and "v8 engine" to tools/v8_gypfiles.
- Add "release" to doc/changelogs.

PR-URL: https://github.com/nodejs/node/pull/38950
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2021-06-08 14:02:44 +02:00
Michaël Zasso
6fe89a1fa6
build: fast-track npm PRs and dont-land them on LTS
PR-URL: https://github.com/nodejs/node/pull/38885
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2021-06-04 13:07:29 +02:00
Michaël Zasso
43cba1dcf1
build: dont-land gyp-next PRs on LTS branches
gyp-next doesn't support Python 3 anymore so we can't backport its
updates.

PR-URL: https://github.com/nodejs/node/pull/38887
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2021-06-03 17:27:14 +02:00
Michaël Zasso
3ec7f300c1
build: remove outdated dont-land-on-v6.x label
PR-URL: https://github.com/nodejs/node/pull/38886
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-06-02 14:53:58 +02:00
Phillip Johnsen
311989f30f
build: label PRs with GitHub Action instead of nodejs-github-bot
Main goal of using a GitHub Action for labelling PRs has been to move
the mapping between files changed -> label into a configuration file
local to the nodejs/node repository.

Previously any changes to that mapping meant having to grasp the
nodejs/github-bot project, open a PR with the neccessary changes, get
approval from its maintainers before those changes finally got pushed
to production.

The logic involved in using the file paths / label configuration and
resolving the labels to be applied, has been moved into a custom GitHub
Action project: nodejs/node-pr-labeler.

Aside from removing the external dependency the nodejs-github-bot is in
practise, it also reduces the bar for contributors since the resulting
project is a lot smaller and less complex than nodejs/github-bot.

PR-URL: https://github.com/nodejs/node/pull/38301
Fixes: https://github.com/nodejs/github-bot/issues/294
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-04-25 07:49:09 +02:00