Mirrors/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-12-28 07:50:41 +00:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

http: remove unused hasItems() from freelist

Browse Source 
Remove the hasItems() method from freelist module as it is unused
internally.

PR-URL: https://github.com/nodejs/node/pull/30744
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
This commit is contained in:
Rich Trott 2019-11-30 17:04:04 -08:00
parent dbdad4d1b5
commit ff2ed3ec85
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/internal/freelist.js
View File

@ -12,10 +12,6 @@ class FreeList {
this.list = [];
}
hasItems() {
return this.list.length > 0;
}
alloc() {
return this.list.length > 0 ?
this.list.pop() :

10
test/parallel/test-freelist.js
View File

@ -28,13 +28,3 @@ assert.strictEqual(flist1.free({ id: 'test5' }), false);
assert.strictEqual(flist1.alloc().id, 'test3');
assert.strictEqual(flist1.alloc().id, 'test2');
assert.strictEqual(flist1.alloc().id, 'test1');
// Check list has elements
const flist2 = new FreeList('flist2', 2, Object);
assert.strictEqual(flist2.hasItems(), false);
flist2.free({ id: 'test1' });
assert.strictEqual(flist2.hasItems(), true);
flist2.alloc();
assert.strictEqual(flist2.hasItems(), false);