Mirrors/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-12-27 23:41:14 +00:00
Code Issues Actions 18 Packages Projects Releases Wiki Activity

v8: adding total_allocated_bytes to HeapStatistics

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/60573
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Caio Lima 2025-11-07 12:56:41 -03:00 committed by GitHub
parent 9495906f8b
commit ed6569c753
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/api/v8.md
View File

@ -197,6 +197,7 @@ Returns an object with the following properties:
* `total_global_handles_size` {number}
* `used_global_handles_size` {number}
* `external_memory` {number}
* `total_allocated_bytes` {number}
`total_heap_size` The value of total\_heap\_size is the number of bytes V8 has
allocated for the heap. This can grow if used\_heap needs more memory.
@ -250,6 +251,9 @@ used memory size of V8 global handles.
`external_memory` The value of external\_memory is the memory size of array
buffers and external strings.
`total_allocated_bytes` The value of total allocated bytes since the Isolate
creation
<!-- eslint-skip -->
```js

2
lib/v8.js
View File

@ -136,6 +136,7 @@ const {
kTotalGlobalHandlesSizeIndex,
kUsedGlobalHandlesSizeIndex,
kExternalMemoryIndex,
kTotalAllocatedBytes,
// Properties for heap spaces statistics buffer extraction.
kHeapSpaces,
@ -246,6 +247,7 @@ function getHeapStatistics() {
total_global_handles_size: buffer[kTotalGlobalHandlesSizeIndex],
used_global_handles_size: buffer[kUsedGlobalHandlesSizeIndex],
external_memory: buffer[kExternalMemoryIndex],
total_allocated_bytes: buffer[kTotalAllocatedBytes],
};
}

3
src/node_v8.cc
View File

@ -73,7 +73,8 @@ using v8::Value;
V(10, number_of_detached_contexts, kNumberOfDetachedContextsIndex) \
V(11, total_global_handles_size, kTotalGlobalHandlesSizeIndex) \
V(12, used_global_handles_size, kUsedGlobalHandlesSizeIndex) \
V(13, external_memory, kExternalMemoryIndex)
V(13, external_memory, kExternalMemoryIndex) \
V(14, total_allocated_bytes, kTotalAllocatedBytes)
#define V(a, b, c) +1
static constexpr size_t kHeapStatisticsPropertiesCount =

4
src/node_worker.cc
View File

@ -1263,6 +1263,7 @@ void Worker::GetHeapStatistics(const FunctionCallbackInfo<Value>& args) {
"total_global_handles_size",
"used_global_handles_size",
"external_memory",
"total_allocated_bytes",
};
tmpl = DictionaryTemplate::New(isolate, heap_stats_names);
env->set_heap_statistics_template(tmpl);
@ -1283,7 +1284,8 @@ void Worker::GetHeapStatistics(const FunctionCallbackInfo<Value>& args) {
Number::New(isolate, heap_stats->number_of_detached_contexts()),
Number::New(isolate, heap_stats->total_global_handles_size()),
Number::New(isolate, heap_stats->used_global_handles_size()),
Number::New(isolate, heap_stats->external_memory())};
Number::New(isolate, heap_stats->external_memory()),
Number::New(isolate, heap_stats->total_allocated_bytes())};
Local<Object> obj;
if (!NewDictionaryInstanceNullProto(

1
test/parallel/test-v8-stats.js
View File

@ -12,6 +12,7 @@ const keys = [
'number_of_detached_contexts',
'number_of_native_contexts',
'peak_malloced_memory',
'total_allocated_bytes',
'total_available_size',
'total_global_handles_size',
'total_heap_size',

1
test/parallel/test-worker-heap-statistics.js
View File

@ -40,6 +40,7 @@ if (isMainThread) {
`total_global_handles_size`,
`used_global_handles_size`,
`external_memory`,
`total_allocated_bytes`,
].sort();
assert.deepStrictEqual(keys, Object.keys(stats).sort());
for (const key of keys) {