Mirrors/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-12-28 07:50:41 +00:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

build: always link with -lz

Browse Source 
Fix building with a shared zlib: ensure link with '-lz'.

Configuring for a shared zlib:

    LDFLAGS="-L/opt/local/lib -R/opt/local/lib" \
        ./configure --shared-zlib \
        --shared-zlib-includes=/opt/local/include \
        --shared-zlib-libpath=/opt/local/lib

and building would fail on SmartOS because the link would not include '-lz'.
This doesn't fail on Mac (at least in my setup) because you get lucky with the
openssl libs reported from the Homebrew pkg-config:

    $ pkg-config --libs openssl
    -lssl -lcrypto -lz

On SmartOS, the pkgsrc libs for openssl are:

    $ pkg-config --libs openssl
    -Wl,-R/opt/local/lib -L/opt/local/lib -lssl -lcrypto -lsocket -lnsl -ldl

The patch has no adverse effect on the Mac build (by control case).
This commit is contained in:
Trent Mick 2012-06-15 20:12:56 -07:00 committed by Ben Noordhuis
parent eef57dddf4
commit dd1c3d72e2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
wscript
View File

@ -296,7 +296,7 @@ def configure(conf):
conf.env["USE_GDBJIT"] = o.use_gdbjit
conf.env['USE_NPM'] = not o.without_npm
if not conf.env["USE_SHARED_ZLIB"] and not sys.platform.startswith("win32"):
if not sys.platform.startswith("win32"):
conf.env.append_value("LINKFLAGS", "-lz")
conf.check(lib='dl', uselib_store='DL')