From c1e03eda07758a08e9469f5aa94038902bf9aacb Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 6 Apr 2019 22:28:25 +0200 Subject: [PATCH] src: use SealHandleScope for inspector tasks This addresses a TODO comment that can be resolved, now that we have V8 7.4. PR-URL: https://github.com/nodejs/node/pull/27116 Reviewed-By: James M Snell Reviewed-By: Joyee Cheung Reviewed-By: Daniel Bevenius --- src/inspector/main_thread_interface.cc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/inspector/main_thread_interface.cc b/src/inspector/main_thread_interface.cc index 5b339a39ae9..ac4461baed4 100644 --- a/src/inspector/main_thread_interface.cc +++ b/src/inspector/main_thread_interface.cc @@ -269,13 +269,7 @@ void MainThreadInterface::DispatchMessages() { std::swap(dispatching_message_queue_.front(), task); dispatching_message_queue_.pop_front(); - // TODO(addaleax): The V8 inspector code currently sometimes allocates - // handles that leak to the outside scope, rendering a HandleScope here - // necessary. This handle scope can be removed/turned into a - // SealHandleScope once/if - // https://chromium-review.googlesource.com/c/v8/v8/+/1484304 makes it - // into our copy of V8, maybe guarded with #ifdef DEBUG if we want. - v8::HandleScope handle_scope(isolate_); + v8::SealHandleScope seal_handle_scope(isolate_); task->Call(this); } } while (had_messages);