Mirrors/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-12-28 07:50:41 +00:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

crypto: fix DOMException name for non-extractable key error

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/60830
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This commit is contained in:
Filip Skokan 2025-11-30 22:45:27 +01:00 committed by GitHub
parent 209a4fe812
commit 94cd600542
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 45 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/internal/crypto/webcrypto.js
View File

@ -676,7 +676,7 @@ async function exportKey(format, key) {
}
if (!key[kExtractable])
throw lazyDOMException('key is not extractable', 'InvalidAccessException');
throw lazyDOMException('key is not extractable', 'InvalidAccessError');
let result;
switch (format) {

12
test/parallel/test-webcrypto-export-import-cfrg.js
View File

@ -134,7 +134,8 @@ async function testImportSpki({ name, publicUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('spki', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -172,7 +173,8 @@ async function testImportPkcs8({ name, privateUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('pkcs8', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -303,11 +305,13 @@ async function testImportJwk({ name, publicUsages, privateUsages }, extractable)
} else {
await assert.rejects(
subtle.exportKey('jwk', publicKey), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
await assert.rejects(
subtle.exportKey('jwk', privateKey), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}

12
test/parallel/test-webcrypto-export-import-ec.js
View File

@ -123,7 +123,8 @@ async function testImportSpki({ name, publicUsages }, namedCurve, extractable) {
} else {
await assert.rejects(
subtle.exportKey('spki', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -165,7 +166,8 @@ async function testImportPkcs8(
} else {
await assert.rejects(
subtle.exportKey('pkcs8', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -270,11 +272,13 @@ async function testImportJwk(
} else {
await assert.rejects(
subtle.exportKey('jwk', publicKey), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
await assert.rejects(
subtle.exportKey('jwk', privateKey), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}

18
test/parallel/test-webcrypto-export-import-ml-dsa.js
View File

@ -106,7 +106,8 @@ async function testImportSpki({ name, publicUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('spki', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -144,7 +145,8 @@ async function testImportPkcs8({ name, privateUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('pkcs8', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -181,7 +183,8 @@ async function testImportPkcs8SeedOnly({ name, privateUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('pkcs8', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -219,7 +222,8 @@ async function testImportPkcs8PrivOnly({ name, privateUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('pkcs8', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -299,11 +303,13 @@ async function testImportJwk({ name, publicUsages, privateUsages }, extractable)
} else {
await assert.rejects(
subtle.exportKey('jwk', publicKey), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
await assert.rejects(
subtle.exportKey('jwk', privateKey), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}

12
test/parallel/test-webcrypto-export-import-ml-kem.js
View File

@ -89,7 +89,8 @@ async function testImportSpki({ name, publicUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('spki', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -127,7 +128,8 @@ async function testImportPkcs8({ name, privateUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('pkcs8', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -164,7 +166,8 @@ async function testImportPkcs8SeedOnly({ name, privateUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('pkcs8', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -202,7 +205,8 @@ async function testImportPkcs8PrivOnly({ name, privateUsages }, extractable) {
} else {
await assert.rejects(
subtle.exportKey('pkcs8', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}

12
test/parallel/test-webcrypto-export-import-rsa.js
View File

@ -336,7 +336,8 @@ async function testImportSpki({ name, publicUsages }, size, hash, extractable) {
} else {
await assert.rejects(
subtle.exportKey('spki', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
}
@ -372,7 +373,8 @@ async function testImportPkcs8(
} else {
await assert.rejects(
subtle.exportKey('pkcs8', key), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}
@ -479,11 +481,13 @@ async function testImportJwk(
} else {
await assert.rejects(
subtle.exportKey('jwk', publicKey), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
await assert.rejects(
subtle.exportKey('jwk', privateKey), {
message: /key is not extractable/
message: /key is not extractable/,
name: 'InvalidAccessError',
});
}