mirror of
https://github.com/nodejs/node.git
synced 2025-12-28 07:50:41 +00:00
build: enable ASLR (PIE) on OS X
After conducting several benchmarks, I noticed performance losses of 5-10%. As OS X is not a performance critical platform, as already mentioned by @bnoordhuis, I have removed the -no_pie flag at least for this platform. I'd love to enable PIE for other platforms if the 5-10% speed loss is not too high. I would be happy to hear your opinion on this. Refs: https://github.com/nodejs/node/issues/33425 PR-URL: https://github.com/nodejs/node/pull/35704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
parent
fff25a0714
commit
8d6b74d347
@ -495,8 +495,7 @@
|
||||
['_type!="static_library"', {
|
||||
'xcode_settings': {
|
||||
'OTHER_LDFLAGS': [
|
||||
'-Wl,-no_pie',
|
||||
'-Wl,-search_paths_first',
|
||||
'-Wl,-search_paths_first'
|
||||
],
|
||||
},
|
||||
}],
|
||||
|
||||
Loading…
Reference in New Issue
Block a user