inspector: undici as shared-library should pass tests
Some checks are pending
Coverage Linux (without intl) / coverage-linux-without-intl (push) Waiting to run
Coverage Linux / coverage-linux (push) Waiting to run
Coverage Windows / coverage-windows (push) Waiting to run
Test and upload documentation to artifacts / build-docs (push) Waiting to run
Linters / lint-addon-docs (push) Waiting to run
Linters / lint-cpp (push) Waiting to run
Linters / format-cpp (push) Waiting to run
Linters / lint-js-and-md (push) Waiting to run
Linters / lint-py (push) Waiting to run
Linters / lint-yaml (push) Waiting to run
Linters / lint-sh (push) Waiting to run
Linters / lint-codeowners (push) Waiting to run
Linters / lint-pr-url (push) Waiting to run
Linters / lint-readme (push) Waiting to run
Notify on Push / Notify on Force Push on `main` (push) Waiting to run
Notify on Push / Notify on Push on `main` that lacks metadata (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run

PR-URL: https://github.com/nodejs/node/pull/59837
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This commit is contained in:
Aras Abbasi 2025-09-10 15:12:28 +02:00 committed by GitHub
parent 8ec29f24fc
commit 861d62445f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -11,6 +11,8 @@ const WebSocketServer = require('../common/websocket-server');
const inspector = require('node:inspector/promises');
const dc = require('diagnostics_channel');
const nameRE = 'undici' in process.versions ? /^node:internal\/deps\/undici\/undici$/u : /undici/u;
const session = new inspector.Session();
session.connect();
@ -18,9 +20,9 @@ dc.channel('undici:websocket:socket_error').subscribe((message) => {
console.error('WebSocket error:', message);
});
function findFrameInInitiator(scriptName, initiator) {
function findFrameInInitiator(regex, initiator) {
const frame = initiator.stack.callFrames.find((it) => {
return it.url === scriptName;
return regex.test(it.url);
});
return frame;
}
@ -39,7 +41,7 @@ async function test() {
assert.ok(message.params.requestId);
assert.strictEqual(typeof message.params.initiator, 'object');
assert.strictEqual(message.params.initiator.type, 'script');
assert.ok(findFrameInInitiator('node:internal/deps/undici/undici', message.params.initiator));
assert.ok(findFrameInInitiator(nameRE, message.params.initiator));
requestId = message.params.requestId;
}));