Mirrors/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-12-28 07:50:41 +00:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

crypto: rewrite HexDecode without snprintf

Browse Source 
No need to use snprintf to create a hex string. It creates
more overhead than is needed. This new version is much faster.
This commit is contained in:
Roman Shtylman 2011-12-01 00:41:06 -05:00 committed by Ben Noordhuis
parent cc2861ee44
commit 4b123f9ca2
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/node_crypto.cc
View File

@ -1699,9 +1699,20 @@ static void HexEncode(unsigned char *md_value,
int* md_hex_len) {
*md_hex_len = (2*(md_len));
*md_hexdigest = new char[*md_hex_len + 1];
for (int i = 0; i < md_len; i++) {
snprintf((char *)(*md_hexdigest + (i*2)), 3, "%02x", md_value[i]);
char* buff = *md_hexdigest;
const int len = *md_hex_len;
for (int i = 0; i < len; i += 2) {
// nibble nibble
const int index = i / 2;
const char msb = (md_value[index] >> 4) & 0x0f;
const char lsb = md_value[index] & 0x0f;
buff[i] = (msb < 10) ? msb + '0' : (msb - 10) + 'a';
buff[i + 1] = (lsb < 10) ? lsb + '0' : (lsb - 10) + 'a';
}
// null terminator
buff[*md_hex_len] = '\0';
}
#define hex2i(c) ((c) <= '9' ? ((c) - '0') : (c) <= 'Z' ? ((c) - 'A' + 10) \