From 1948d3759585936842cfabe237756e58f2a14d34 Mon Sep 17 00:00:00 2001
From: Umuoy <burningdian@gmail.com>
Date: Mon, 3 Apr 2023 16:24:24 +0800
Subject: [PATCH] buffer: check INSPECT_MAX_BYTES with validateNumber

PR-URL: https://github.com/nodejs/node/pull/46599
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
---
 lib/buffer.js                                 |  5 ++-
 .../test-buffer-set-inspect-max-bytes.js      | 34 +++++++++++++++++++
 2 files changed, 38 insertions(+), 1 deletion(-)
 create mode 100644 test/parallel/test-buffer-set-inspect-max-bytes.js

diff --git a/lib/buffer.js b/lib/buffer.js
index fc177d01f06..ec20e3432fc 100644
--- a/lib/buffer.js
+++ b/lib/buffer.js
@@ -1401,7 +1401,10 @@ ObjectDefineProperties(module.exports, {
     configurable: true,
     enumerable: true,
     get() { return INSPECT_MAX_BYTES; },
-    set(val) { INSPECT_MAX_BYTES = val; },
+    set(val) {
+      validateNumber(val, 'INSPECT_MAX_BYTES', 0);
+      INSPECT_MAX_BYTES = val;
+    },
   },
 });
 
diff --git a/test/parallel/test-buffer-set-inspect-max-bytes.js b/test/parallel/test-buffer-set-inspect-max-bytes.js
new file mode 100644
index 00000000000..975c828111e
--- /dev/null
+++ b/test/parallel/test-buffer-set-inspect-max-bytes.js
@@ -0,0 +1,34 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const buffer = require('buffer');
+
+const rangeErrorObjs = [NaN, -1];
+const typeErrorObj = 'and even this';
+
+for (const obj of rangeErrorObjs) {
+  assert.throws(
+    () => buffer.INSPECT_MAX_BYTES = obj,
+    {
+      code: 'ERR_OUT_OF_RANGE',
+      name: 'RangeError',
+    }
+  );
+
+  assert.throws(
+    () => buffer.INSPECT_MAX_BYTES = obj,
+    {
+      code: 'ERR_OUT_OF_RANGE',
+      name: 'RangeError',
+    }
+  );
+}
+
+assert.throws(
+  () => buffer.INSPECT_MAX_BYTES = typeErrorObj,
+  {
+    code: 'ERR_INVALID_ARG_TYPE',
+    name: 'TypeError',
+  }
+);