Mirrors/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-28 06:34:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cmd/link: add new linknames to blocked linkname list

Browse Source 
Update the blocklist with new linknames added in Go 1.26.

Some goroutine leak profile symbols were manually added but they
did not match the actual symbol names. Corrected.

runtime.freegc is not itself push-linknamed, so there is no need
to explicitly add it to blocklist. Keep the test, to ensure one
cannot linkname-pull freegc.

Change-Id: Ie5fd6bc191e9afa164fa79055cc39e6fa9ed4c7f
Reviewed-on: https://go-review.googlesource.com/c/go/+/729720
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
This commit is contained in:
Cherry Mui 2025-12-12 13:00:54 -05:00
parent 8d31244562
commit 34af879dde
1 changed files with 26 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/cmd/link/internal/loader/loader.go
View File

@ -2420,6 +2420,7 @@ var blockedLinknames = map[string][]string{
"internal/runtime/maps.fatal": {"internal/runtime/maps"},
"internal/runtime/maps.newarray": {"internal/runtime/maps"},
"internal/runtime/maps.newobject": {"internal/runtime/maps"},
"internal/runtime/maps.rand": {"internal/runtime/maps"},
"internal/runtime/maps.typedmemclr": {"internal/runtime/maps"},
"internal/runtime/maps.typedmemmove": {"internal/runtime/maps"},
"internal/sync.fatal": {"internal/sync"},
@ -2449,8 +2450,6 @@ var blockedLinknames = map[string][]string{
"runtime.mapdelete_faststr": {"runtime"},
// New internal linknames in Go 1.25
// Pushed from runtime
"crypto/subtle.setDITEnabled": {"crypto/subtle"},
"crypto/subtle.setDITDisabled": {"crypto/subtle"},
"internal/cpu.riscvHWProbe": {"internal/cpu"},
"internal/runtime/cgroup.throw": {"internal/runtime/cgroup"},
"internal/runtime/maps.typeString": {"internal/runtime/maps"},
@ -2463,14 +2462,34 @@ var blockedLinknames = map[string][]string{
"sync_test.runtime_blockUntilEmptyCleanupQueue": {"sync_test"},
"time.runtimeIsBubbled": {"time"},
"unique.runtime_blockUntilEmptyCleanupQueue": {"unique"},
// Experimental features
"runtime.goroutineLeakGC": {"runtime/pprof"},
"runtime.goroutineleakcount": {"runtime/pprof"},
"runtime.freegc": {}, // disallow all packages
// Others
"net.newWindowsFile": {"net"}, // pushed from os
"testing/synctest.testingSynctestTest": {"testing/synctest"}, // pushed from testing
"runtime.addmoduledata": {}, // disallow all packages
// New internal linknames in Go 1.26
// Pushed from runtime
"crypto/fips140.isBypassed": {"crypto/fips140"},
"crypto/fips140.setBypass": {"crypto/fips140"},
"crypto/fips140.unsetBypass": {"crypto/fips140"},
"crypto/subtle.setDITEnabled": {"crypto/subtle"},
"crypto/subtle.setDITDisabled": {"crypto/subtle"},
"internal/cpu.sysctlbynameBytes": {"internal/cpu"},
"internal/cpu.sysctlbynameInt32": {"internal/cpu"},
"runtime.pprof_goroutineLeakProfileWithLabels": {"runtime/pprof"},
"runtime/pprof.runtime_goroutineLeakGC": {"runtime/pprof"},
"runtime/pprof.runtime_goroutineleakcount": {"runtime/pprof"},
"runtime/secret.appendSignalStacks": {"runtime/secret"},
"runtime/secret.count": {"runtime/secret"},
"runtime/secret.dec": {"runtime/secret"},
"runtime/secret.eraseSecrets": {"runtime/secret"},
"runtime/secret.getStack": {"runtime/secret"},
"runtime/secret.inc": {"runtime/secret"},
"syscall.rawsyscalln": {"syscall"},
"syscall.runtimeClearenv": {"syscall"},
"syscall.syscalln": {"syscall"},
// Others
"crypto/internal/rand.SetTestingReader": {"testing/cryptotest"}, // pushed from crypto/internal/rand
"testing.checkParallel": {"testing/cryptotest"}, // pushed from testing
"runtime.addmoduledata": {}, // assembly symbol, disallow all packages
}
// check if a linkname reference to symbol s from pkg is allowed