Mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web.git synced 2025-12-28 07:14:20 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

call: Pass the echo cancellation and noise suppression settings to EC (#31317)

Browse Source
This commit is contained in:
Valere Fedronic 2025-12-04 15:59:48 +01:00 committed by GitHub
parent e7be9d16b9
commit dc67863cbc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 101 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/models/Call.ts
View File

@ -744,6 +744,17 @@ export class ElementCall extends Call {
params.append("allowIceFallback", "true");
}
const echoCancellation = SettingsStore.getValue("webrtc_audio_echoCancellation");
if (!echoCancellation) {
// the default is true, so only set if false
params.append("echoCancellation", "false");
}
const noiseSuppression = SettingsStore.getValue("webrtc_audio_noiseSuppression");
if (!noiseSuppression) {
// the default is true, so only set if false
params.append("noiseSuppression", "false");
}
// Set custom fonts
if (SettingsStore.getValue("useSystemFont")) {
SettingsStore.getValue("systemFont")

90
test/unit-tests/models/Call-test.ts
View File

@ -567,6 +567,96 @@ describe("ElementCall", () => {
SettingsStore.getValue = originalGetValue;
});
describe("Echo cancellation & Noise Suppression", () => {
it("passes echo cancellation settings through widget URL if needed", async () => {
const originalGetValue = SettingsStore.getValue;
SettingsStore.getValue = (
name: SettingKey,
roomId: string | null = null,
excludeDefault = false,
): any => {
switch (name) {
case "webrtc_audio_echoCancellation":
return false;
}
};
ElementCall.create(room);
const call = Call.get(room);
if (!(call instanceof ElementCall)) throw new Error("Failed to create call");
const urlParams = new URLSearchParams(new URL(call.widget.url).hash.slice(1));
expect(urlParams.get("echoCancellation")).toBe("false");
SettingsStore.getValue = originalGetValue;
});
it("does not pass echo cancellation settings through widget URL if not needed", async () => {
const originalGetValue = SettingsStore.getValue;
SettingsStore.getValue = (
name: SettingKey,
roomId: string | null = null,
excludeDefault = false,
): any => {
switch (name) {
case "webrtc_audio_echoCancellation":
return true;
}
};
ElementCall.create(room);
const call = Call.get(room);
if (!(call instanceof ElementCall)) throw new Error("Failed to create call");
const urlParams = new URLSearchParams(new URL(call.widget.url).hash.slice(1));
expect(urlParams.get("echoCancellation")).toBeNull();
SettingsStore.getValue = originalGetValue;
});
it("passes noise suppression settings through widget URL if needed", async () => {
const originalGetValue = SettingsStore.getValue;
SettingsStore.getValue = (
name: SettingKey,
roomId: string | null = null,
excludeDefault = false,
): any => {
switch (name) {
case "webrtc_audio_noiseSuppression":
return false;
}
};
ElementCall.create(room);
const call = Call.get(room);
if (!(call instanceof ElementCall)) throw new Error("Failed to create call");
const urlParams = new URLSearchParams(new URL(call.widget.url).hash.slice(1));
expect(urlParams.get("noiseSuppression")).toBe("false");
SettingsStore.getValue = originalGetValue;
});
it("does not pass noise suppression settings through widget URL if not needed", async () => {
const originalGetValue = SettingsStore.getValue;
SettingsStore.getValue = (
name: SettingKey,
roomId: string | null = null,
excludeDefault = false,
): any => {
switch (name) {
case "webrtc_audio_noiseSuppression":
return true;
}
};
ElementCall.create(room);
const call = Call.get(room);
if (!(call instanceof ElementCall)) throw new Error("Failed to create call");
const urlParams = new URLSearchParams(new URL(call.widget.url).hash.slice(1));
expect(urlParams.get("noiseSuppression")).toBeNull();
SettingsStore.getValue = originalGetValue;
});
});
it("passes ICE fallback preference through widget URL", async () => {
// Test with the preference set to false
ElementCall.create(room);