Mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web.git synced 2025-12-28 07:14:20 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Ensure switching rooms does not wrongly focus timeline search (#29153)
Some checks failed
Build / Build on ${{ matrix.image }} (macos-14, ${{ github.event_name == 'push' && github.ref_name == 'develop' }}, ${{ github.event_name == 'pull_request' }}) (push) Waiting to run
Details
Build / Build on ${{ matrix.image }} (ubuntu-24.04, ${{ github.event_name == 'push' && github.ref_name == 'develop' }}, ${{ github.event_name == 'pull_request' }}) (push) Waiting to run
Details
Build / Build on ${{ matrix.image }} (windows-2022, ${{ github.event_name == 'push' && github.ref_name == 'develop' }}, ${{ github.event_name == 'pull_request' }}) (push) Waiting to run
Details
Build and Deploy develop / Build & Deploy develop.element.io (push) Waiting to run
Details
Deploy documentation / GitHub Pages (push) Waiting to run
Details
Deploy documentation / deploy (push) Blocked by required conditions
Details
Static Analysis / Typescript Syntax Check (push) Waiting to run
Details
Static Analysis / i18n Check (push) Waiting to run
Details
Static Analysis / Rethemendex Check (push) Waiting to run
Details
Static Analysis / ESLint (push) Waiting to run
Details
Static Analysis / Style Lint (push) Waiting to run
Details
Static Analysis / Workflow Lint (push) Waiting to run
Details
Static Analysis / Analyse Dead Code (push) Waiting to run
Details
Localazy Upload / upload (push) Has been cancelled
Details

Browse Source 
This happened due to the focusRoomSearch param being stored for inactive rooms so it never got cleared

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski 2025-01-31 15:47:32 +00:00 committed by GitHub
parent d3a6f34881
commit b64471e4f6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/stores/right-panel/RightPanelStoreIPanelState.ts
View File

@ -38,8 +38,6 @@ export interface IRightPanelCardStateStored {
initialEventId?: string;
isInitialEventHighlighted?: boolean;
initialEventScrollIntoView?: boolean;
// room summary card
focusRoomSearch?: boolean;
}
export interface IRightPanelCard {
@ -84,7 +82,6 @@ export function convertCardToStore(panelState: IRightPanelCard): IRightPanelCard
memberInfoEventId: !!state?.memberInfoEvent?.getId() ? state.memberInfoEvent.getId() : undefined,
initialEventId: !!state?.initialEvent?.getId() ? state.initialEvent.getId() : undefined,
memberId: !!state?.member?.userId ? state.member.userId : undefined,
focusRoomSearch: state.focusRoomSearch,
};
return { state: stateStored, phase: panelState.phase };
@ -104,7 +101,6 @@ function convertStoreToCard(panelStateStore: IRightPanelCardStored, room: Room):
: undefined,
initialEvent: !!stateStored?.initialEventId ? room.findEventById(stateStored.initialEventId) : undefined,
member: (!!stateStored?.memberId && room.getMember(stateStored.memberId)) || undefined,
focusRoomSearch: stateStored?.focusRoomSearch,
};
return { state: state, phase: panelStateStore.phase };