Mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web.git synced 2025-12-28 07:14:20 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Fix test that doesn't make sense in usePublicRoomDirectory-test.tsx (#29335)

Browse Source 
* remove test that doesn't make sense

* Actually let's fix the test rather than remove it

* Add comment, remove consoles.
This commit is contained in:
David Langley 2025-02-22 00:17:13 +00:00 committed by GitHub
parent 0cbc6f99d0
commit 27c0e97e44
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/unit-tests/hooks/usePublicRoomDirectory-test.tsx
View File

@ -27,17 +27,15 @@ describe("usePublicRoomDirectory", () => {
cli.getDomain = () => "matrix.org";
cli.getThirdpartyProtocols = () => Promise.resolve({});
cli.publicRooms = ({ filter }: IRoomDirectoryOptions) => {
const chunk = filter?.generic_search_term
? [
{
room_id: "hello world!",
name: filter.generic_search_term,
world_readable: true,
guest_can_join: true,
num_joined_members: 1,
},
]
: [];
const chunk = [
{
room_id: "hello world!",
name: filter?.generic_search_term ?? "", // If the query is "" no filter is applied(an is undefined here), in keeping with the pattern let's call the room ""
world_readable: true,
guest_can_join: true,
num_joined_members: 1,
},
];
return Promise.resolve({
chunk,
total_room_count_estimate: 1,
@ -67,7 +65,7 @@ describe("usePublicRoomDirectory", () => {
});
it("should work with empty queries", async () => {
const query = "ROOM NAME";
const query = "";
const { result } = render();
act(() => {