Mirrors/duckstation
1
0
Fork 0
mirror of https://github.com/stenzek/duckstation.git synced 2025-12-28 05:24:19 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

GPU/HW: Chunk skewed+overlapping copies
Some checks failed
Automated Builds / 💻 Windows (push) Waiting to run
Details
Automated Builds / 🐧 Linux AppImage (push) Waiting to run
Details
Automated Builds / 🐧 Linux Cross-Compiled AppImage (push) Waiting to run
Details
Automated Builds / 🍎 MacOS (push) Waiting to run
Details
Automated Builds / 📤 Create Release (push) Blocked by required conditions
Details
Translation Lint / translation-lint (push) Has been cancelled
Details

Browse Source 
Can't see any retail games that do this from a quick check..
This commit is contained in:
Stenzek 2025-12-14 02:25:23 +10:00
parent c6a44ff569
commit 7cf6e04257
No known key found for this signature in database
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/core/gpu_hw.cpp
View File

@ -176,6 +176,12 @@ ALWAYS_INLINE static u32 Truncate32To16(u32 color)
.rgba32();
}
/// Returns true if two given spans overlap.
ALWAYS_INLINE static bool SpansOverlap(s32 start1, s32 end1, s32 start2, s32 end2)
{
return (start1 <= end2 && start2 <= end1);
}
/// Computes the clamped average Z for the given polygon Z values.
template<typename... Args>
ALWAYS_INLINE static float ComputePolygonAverageZ(Args... args)
@ -3600,6 +3606,26 @@ void GPU_HW::CopyVRAM(u32 src_x, u32 src_y, u32 dst_x, u32 dst_y, u32 width, u32
GPU_SW_Rasterizer::CopyVRAM(src_x, src_y, dst_x, dst_y, width, height, set_mask, check_mask);
}
if (overlaps_with_self && src_x != dst_x && src_y != dst_y &&
SpansOverlap(src_x, src_x + width, dst_x, dst_x + width) &&
SpansOverlap(src_y, src_y + height, dst_y, dst_y + height))
{
const u32 chunk_size = std::min(std::max(src_y, dst_y) - std::min(src_y, dst_y), height);
if (chunk_size < height)
{
WARNING_LOG("Breaking {}x{} copy into {} high chunks ({},{} => {},{})", width, height, chunk_size, src_x, src_y,
dst_x, dst_y);
for (u32 chunk_dst_y = dst_y; chunk_dst_y < dst_y + height; chunk_dst_y += chunk_size)
{
const u32 chunk_src_y = src_y + (chunk_dst_y - dst_y);
const u32 current_chunk_height = std::min(chunk_size, (dst_y + height) - chunk_dst_y);
CopyVRAM(src_x, chunk_src_y, dst_x, chunk_dst_y, width, current_chunk_height, set_mask, check_mask);
}
}
return;
}
if (use_shader || IsUsingMultisampling())
{
if (intersect_with_draw || intersect_with_write)