mirror of
https://github.com/coollabsio/coolify.git
synced 2025-12-28 05:34:50 +00:00
Changed from `->before('-')` to `->beforeLast('-')` to correctly parse service
names with hyphens. This fixes prerequisite application for ~230+ services
containing hyphens in their template names (e.g., docker-registry,
elasticsearch-with-kibana).
Added comprehensive test coverage for hyphenated service names and fixed
existing tests to use realistic CUID2 UUID format. All unit tests pass.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
133 lines
4.0 KiB
PHP
133 lines
4.0 KiB
PHP
<?php
|
|
|
|
use App\Actions\Server\UpdateCoolify;
|
|
use App\Models\InstanceSettings;
|
|
use App\Models\Server;
|
|
use Illuminate\Support\Facades\Cache;
|
|
use Illuminate\Support\Facades\Http;
|
|
|
|
beforeEach(function () {
|
|
// Mock Server
|
|
$this->mockServer = Mockery::mock(Server::class)->makePartial();
|
|
$this->mockServer->id = 0;
|
|
|
|
// Mock InstanceSettings
|
|
$this->settings = Mockery::mock(InstanceSettings::class);
|
|
$this->settings->is_auto_update_enabled = true;
|
|
$this->settings->shouldReceive('save')->andReturn(true);
|
|
});
|
|
|
|
afterEach(function () {
|
|
Mockery::close();
|
|
});
|
|
|
|
it('has UpdateCoolify action class', function () {
|
|
expect(class_exists(UpdateCoolify::class))->toBeTrue();
|
|
});
|
|
|
|
it('validates cache against running version before fallback', function () {
|
|
// Mock Server::find to return our mock server
|
|
Server::shouldReceive('find')
|
|
->with(0)
|
|
->andReturn($this->mockServer);
|
|
|
|
// Mock instanceSettings
|
|
$this->app->instance('App\Models\InstanceSettings', function () {
|
|
return $this->settings;
|
|
});
|
|
|
|
// CDN fails
|
|
Http::fake(['*' => Http::response(null, 500)]);
|
|
|
|
// Mock cache returning older version
|
|
Cache::shouldReceive('remember')
|
|
->andReturn(['coolify' => ['v4' => ['version' => '4.0.5']]]);
|
|
|
|
config(['constants.coolify.version' => '4.0.10']);
|
|
|
|
$action = new UpdateCoolify;
|
|
|
|
// Should throw exception - cache is older than running
|
|
try {
|
|
$action->handle(manual_update: false);
|
|
expect(false)->toBeTrue('Expected exception was not thrown');
|
|
} catch (\Exception $e) {
|
|
expect($e->getMessage())->toContain('cache version');
|
|
expect($e->getMessage())->toContain('4.0.5');
|
|
expect($e->getMessage())->toContain('4.0.10');
|
|
}
|
|
});
|
|
|
|
it('uses validated cache when CDN fails and cache is newer', function () {
|
|
// Mock Server::find
|
|
Server::shouldReceive('find')
|
|
->with(0)
|
|
->andReturn($this->mockServer);
|
|
|
|
// Mock instanceSettings
|
|
$this->app->instance('App\Models\InstanceSettings', function () {
|
|
return $this->settings;
|
|
});
|
|
|
|
// CDN fails
|
|
Http::fake(['*' => Http::response(null, 500)]);
|
|
|
|
// Cache has newer version than current
|
|
Cache::shouldReceive('remember')
|
|
->andReturn(['coolify' => ['v4' => ['version' => '4.0.10']]]);
|
|
|
|
config(['constants.coolify.version' => '4.0.5']);
|
|
|
|
// Mock the update method to prevent actual update
|
|
$action = Mockery::mock(UpdateCoolify::class)->makePartial();
|
|
$action->shouldReceive('update')->once();
|
|
$action->server = $this->mockServer;
|
|
|
|
\Illuminate\Support\Facades\Log::shouldReceive('warning')
|
|
->once()
|
|
->with('Failed to fetch fresh version from CDN, using validated cache', Mockery::type('array'));
|
|
|
|
// Should not throw - cache (4.0.10) > running (4.0.5)
|
|
$action->handle(manual_update: false);
|
|
|
|
expect($action->latestVersion)->toBe('4.0.10');
|
|
});
|
|
|
|
it('prevents downgrade even with manual update', function () {
|
|
// Mock Server::find
|
|
Server::shouldReceive('find')
|
|
->with(0)
|
|
->andReturn($this->mockServer);
|
|
|
|
// Mock instanceSettings
|
|
$this->app->instance('App\Models\InstanceSettings', function () {
|
|
return $this->settings;
|
|
});
|
|
|
|
// CDN returns older version
|
|
Http::fake([
|
|
'*' => Http::response([
|
|
'coolify' => ['v4' => ['version' => '4.0.0']],
|
|
], 200),
|
|
]);
|
|
|
|
// Current version is newer
|
|
config(['constants.coolify.version' => '4.0.10']);
|
|
|
|
$action = new UpdateCoolify;
|
|
|
|
\Illuminate\Support\Facades\Log::shouldReceive('error')
|
|
->once()
|
|
->with('Downgrade prevented', Mockery::type('array'));
|
|
|
|
// Should throw exception even for manual updates
|
|
try {
|
|
$action->handle(manual_update: true);
|
|
expect(false)->toBeTrue('Expected exception was not thrown');
|
|
} catch (\Exception $e) {
|
|
expect($e->getMessage())->toContain('Cannot downgrade');
|
|
expect($e->getMessage())->toContain('4.0.10');
|
|
expect($e->getMessage())->toContain('4.0.0');
|
|
}
|
|
});
|