mirror of
https://github.com/coollabsio/coolify.git
synced 2025-12-28 05:34:50 +00:00
- Replace manual regex parsing with DockerImageParser in ApplicationsController - Fix double-decoration bug where image names like nginx@sha256:hash would become nginx:hash@sha256 causing malformed references - Add auto-parse feature in Livewire DockerImage component - Users can now paste complete references like nginx:stable@sha256:abc123... and fields auto-populate - Update UI placeholder with examples: nginx, docker.io/nginx:latest, ghcr.io/user/app:v1.2.3, nginx:stable@sha256:abc123... - Add comprehensive unit tests for auto-parse functionality - All tests passing (20 tests, 73 assertions) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
142 lines
5.7 KiB
PHP
142 lines
5.7 KiB
PHP
<?php
|
|
|
|
use App\Services\DockerImageParser;
|
|
|
|
it('parses regular image with tag', function () {
|
|
$parser = new DockerImageParser;
|
|
$parser->parse('nginx:latest');
|
|
|
|
expect($parser->getImageName())->toBe('nginx')
|
|
->and($parser->getTag())->toBe('latest')
|
|
->and($parser->isImageHash())->toBeFalse()
|
|
->and($parser->toString())->toBe('nginx:latest');
|
|
});
|
|
|
|
it('parses image with sha256 hash using colon format', function () {
|
|
$parser = new DockerImageParser;
|
|
$hash = '59e02939b1bf39f16c93138a28727aec520bb916da021180ae502c61626b3cf0';
|
|
$parser->parse("ghcr.io/benjaminehowe/rail-disruptions:{$hash}");
|
|
|
|
expect($parser->getFullImageNameWithoutTag())->toBe('ghcr.io/benjaminehowe/rail-disruptions')
|
|
->and($parser->getTag())->toBe($hash)
|
|
->and($parser->isImageHash())->toBeTrue()
|
|
->and($parser->toString())->toBe("ghcr.io/benjaminehowe/rail-disruptions@sha256:{$hash}")
|
|
->and($parser->getFullImageNameWithHash())->toBe("ghcr.io/benjaminehowe/rail-disruptions@sha256:{$hash}");
|
|
});
|
|
|
|
it('parses image with sha256 hash using at sign format', function () {
|
|
$parser = new DockerImageParser;
|
|
$hash = '59e02939b1bf39f16c93138a28727aec520bb916da021180ae502c61626b3cf0';
|
|
$parser->parse("nginx@sha256:{$hash}");
|
|
|
|
expect($parser->getImageName())->toBe('nginx')
|
|
->and($parser->getTag())->toBe($hash)
|
|
->and($parser->isImageHash())->toBeTrue()
|
|
->and($parser->toString())->toBe("nginx@sha256:{$hash}")
|
|
->and($parser->getFullImageNameWithHash())->toBe("nginx@sha256:{$hash}");
|
|
});
|
|
|
|
it('parses registry image with hash', function () {
|
|
$parser = new DockerImageParser;
|
|
$hash = 'abc123def456789abcdef123456789abcdef123456789abcdef123456789abc1';
|
|
$parser->parse("docker.io/library/nginx:{$hash}");
|
|
|
|
expect($parser->getFullImageNameWithoutTag())->toBe('docker.io/library/nginx')
|
|
->and($parser->getTag())->toBe($hash)
|
|
->and($parser->isImageHash())->toBeTrue()
|
|
->and($parser->toString())->toBe("docker.io/library/nginx@sha256:{$hash}");
|
|
});
|
|
|
|
it('parses image without tag defaults to latest', function () {
|
|
$parser = new DockerImageParser;
|
|
$parser->parse('nginx');
|
|
|
|
expect($parser->getImageName())->toBe('nginx')
|
|
->and($parser->getTag())->toBe('latest')
|
|
->and($parser->isImageHash())->toBeFalse()
|
|
->and($parser->toString())->toBe('nginx:latest');
|
|
});
|
|
|
|
it('parses registry with port', function () {
|
|
$parser = new DockerImageParser;
|
|
$parser->parse('registry.example.com:5000/myapp:latest');
|
|
|
|
expect($parser->getFullImageNameWithoutTag())->toBe('registry.example.com:5000/myapp')
|
|
->and($parser->getTag())->toBe('latest')
|
|
->and($parser->isImageHash())->toBeFalse();
|
|
});
|
|
|
|
it('parses registry with port and hash', function () {
|
|
$parser = new DockerImageParser;
|
|
$hash = '1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef';
|
|
$parser->parse("registry.example.com:5000/myapp:{$hash}");
|
|
|
|
expect($parser->getFullImageNameWithoutTag())->toBe('registry.example.com:5000/myapp')
|
|
->and($parser->getTag())->toBe($hash)
|
|
->and($parser->isImageHash())->toBeTrue()
|
|
->and($parser->toString())->toBe("registry.example.com:5000/myapp@sha256:{$hash}");
|
|
});
|
|
|
|
it('identifies valid sha256 hashes', function () {
|
|
$validHashes = [
|
|
'59e02939b1bf39f16c93138a28727aec520bb916da021180ae502c61626b3cf0',
|
|
'1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef',
|
|
'abcdef1234567890abcdef1234567890abcdef1234567890abcdef1234567890',
|
|
];
|
|
|
|
foreach ($validHashes as $hash) {
|
|
$parser = new DockerImageParser;
|
|
$parser->parse("image:{$hash}");
|
|
expect($parser->isImageHash())->toBeTrue("Hash {$hash} should be recognized as valid SHA256");
|
|
}
|
|
});
|
|
|
|
it('identifies invalid sha256 hashes', function () {
|
|
$invalidHashes = [
|
|
'latest',
|
|
'v1.2.3',
|
|
'abc123', // too short
|
|
'59e02939b1bf39f16c93138a28727aec520bb916da021180ae502c61626b3cf', // too short
|
|
'59e02939b1bf39f16c93138a28727aec520bb916da021180ae502c61626b3cf00', // too long
|
|
'59e02939b1bf39f16c93138a28727aec520bb916da021180ae502c61626b3cfg0', // invalid char
|
|
];
|
|
|
|
foreach ($invalidHashes as $hash) {
|
|
$parser = new DockerImageParser;
|
|
$parser->parse("image:{$hash}");
|
|
expect($parser->isImageHash())->toBeFalse("Hash {$hash} should not be recognized as valid SHA256");
|
|
}
|
|
});
|
|
|
|
it('correctly parses and normalizes image with full digest including hash', function () {
|
|
$parser = new DockerImageParser;
|
|
$hash = '59e02939b1bf39f16c93138a28727aec520bb916da021180ae502c61626b3cf0';
|
|
$parser->parse("nginx@sha256:{$hash}");
|
|
|
|
expect($parser->getImageName())->toBe('nginx')
|
|
->and($parser->getTag())->toBe($hash)
|
|
->and($parser->isImageHash())->toBeTrue()
|
|
->and($parser->getFullImageNameWithoutTag())->toBe('nginx')
|
|
->and($parser->toString())->toBe("nginx@sha256:{$hash}");
|
|
});
|
|
|
|
it('correctly parses image when user provides digest-decorated name with colon hash', function () {
|
|
$parser = new DockerImageParser;
|
|
$hash = 'deadbeef1234567890abcdef1234567890abcdef1234567890abcdef12345678';
|
|
|
|
// User might provide: nginx@sha256:deadbeef...
|
|
// This should be parsed correctly without duplication
|
|
$parser->parse("nginx@sha256:{$hash}");
|
|
|
|
$imageName = $parser->getFullImageNameWithoutTag();
|
|
if ($parser->isImageHash() && ! str_ends_with($imageName, '@sha256')) {
|
|
$imageName .= '@sha256';
|
|
}
|
|
|
|
// The result should be: nginx@sha256 (name) + deadbeef... (tag)
|
|
// NOT: nginx:deadbeef...@sha256 or nginx@sha256:deadbeef...@sha256
|
|
expect($imageName)->toBe('nginx@sha256')
|
|
->and($parser->getTag())->toBe($hash)
|
|
->and($parser->isImageHash())->toBeTrue();
|
|
});
|