Mirrors/Rocket.Chat
1
0
Fork 0
mirror of https://github.com/RocketChat/Rocket.Chat.git synced 2025-12-27 22:40:49 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

chore(meteor-methods)!: remove deprecated canAccessRoom method (#35436)

Browse Source 
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
This commit is contained in:
sudhanshu tiwary 2025-05-13 00:48:15 +05:30 committed by Guilherme Gazzo
parent 7037ab5c78
commit bd10778e8b
3 changed files with 5 additions and 71 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/few-masks-punch.md Normal file
View File

@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": major
---
Removes deprecated `canAccessRoom` meteor method

70
apps/meteor/server/methods/canAccessRoom.ts
View File

@ -1,70 +0,0 @@
import type { IRoom, IUser } from '@rocket.chat/core-typings';
import type { ServerMethods } from '@rocket.chat/ddp-client';
import { Rooms, Users } from '@rocket.chat/models';
import { Match, check } from 'meteor/check';
import { Meteor } from 'meteor/meteor';
import { canAccessRoomAsync } from '../../app/authorization/server';
import { settings } from '../../app/settings/server';
declare module '@rocket.chat/ddp-client' {
// eslint-disable-next-line @typescript-eslint/naming-convention
interface ServerMethods {
canAccessRoom(rid: IRoom['_id'], userId: IUser['_id'], extraData?: Record<string, unknown>): (IRoom & { username?: string }) | boolean;
}
}
if (['yes', 'true'].includes(String(process.env.ALLOW_CANACCESSROOM_METHOD).toLowerCase())) {
console.warn('Method canAccessRoom is deprecated and will be removed after version 5.0');
Meteor.methods<ServerMethods>({
async canAccessRoom(rid, userId, extraData) {
check(rid, String);
check(userId, Match.Maybe(String));
let user;
if (userId) {
user = await Users.findOneById(userId, {
projection: {
username: 1,
},
});
if (!user?.username) {
throw new Meteor.Error('error-invalid-user', 'Invalid user', {
method: 'canAccessRoom',
});
}
}
if (!rid) {
throw new Meteor.Error('error-invalid-room', 'Invalid room', {
method: 'canAccessRoom',
});
}
const room = await Rooms.findOneById(rid);
if (!room) {
throw new Meteor.Error('error-invalid-room', 'Invalid room', {
method: 'canAccessRoom',
});
}
if (await canAccessRoomAsync(room, user, extraData)) {
if (user) {
return { ...room, username: user.username };
}
return room;
}
if (!userId && settings.get('Accounts_AllowAnonymousRead') === false) {
throw new Meteor.Error('error-invalid-user', 'Invalid user', {
method: 'canAccessRoom',
});
}
return false;
},
});
}

1
apps/meteor/server/methods/index.ts
View File

@ -7,7 +7,6 @@ import './addRoomModerator';
import './addRoomOwner';
import './afterVerifyEmail';
import './browseChannels';
import './canAccessRoom';
import './channelsList';
import './createDirectMessage';
import './deleteFileMessage';