Mirrors/Rocket.Chat
1
0
Fork 0
mirror of https://github.com/RocketChat/Rocket.Chat.git synced 2025-12-28 06:47:25 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

chore!: Remove deprecated authorization:deleteRole method

Browse Source
This commit is contained in:
MartinSchoeler 2025-09-03 16:57:34 -03:00 committed by Guilherme Gazzo
parent 1631693642
commit 5061423429
3 changed files with 5 additions and 72 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/pink-months-compare.md Normal file
View File

@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": major
---
Removes the deprecated `authorization:deleteRole` method

1
apps/meteor/app/authorization/server/index.ts
View File

@ -4,7 +4,6 @@ import { getUsersInRole } from './functions/getUsersInRole';
import { subscriptionHasRole } from './functions/hasRole';
import './methods/addPermissionToRole';
import './methods/addUserToRole';
import './methods/deleteRole';
import './methods/removeRoleFromPermission';
import './streamer/permissions';

71
apps/meteor/app/authorization/server/methods/deleteRole.ts
View File

@ -1,71 +0,0 @@
import type { IRole } from '@rocket.chat/core-typings';
import type { ServerMethods } from '@rocket.chat/ddp-client';
import { Roles } from '@rocket.chat/models';
import { Meteor } from 'meteor/meteor';
import type { DeleteResult } from 'mongodb';
import { methodDeprecationLogger } from '../../../lib/server/lib/deprecationWarningLogger';
import { hasPermissionAsync } from '../functions/hasPermission';
declare module '@rocket.chat/ddp-client' {
// eslint-disable-next-line @typescript-eslint/naming-convention
interface ServerMethods {
'authorization:deleteRole'(roleId: IRole['_id'] | IRole['name']): Promise<DeleteResult>;
}
}
Meteor.methods<ServerMethods>({
async 'authorization:deleteRole'(roleId) {
methodDeprecationLogger.method('authorization:deleteRole', '8.0.0', '/v1/roles.delete');
const userId = Meteor.userId();
if (!userId || !(await hasPermissionAsync(userId, 'access-permissions'))) {
throw new Meteor.Error('error-action-not-allowed', 'Accessing permissions is not allowed', {
method: 'authorization:deleteRole',
action: 'Accessing_permissions',
});
}
const options = {
projection: {
_id: 1,
protected: 1,
},
};
let role = await Roles.findOneById<Pick<IRole, '_id' | 'protected'>>(roleId, options);
if (!role) {
role = await Roles.findOneByName<Pick<IRole, '_id' | 'protected'>>(roleId, options);
if (!role) {
throw new Meteor.Error('error-invalid-role', 'Invalid role', {
method: 'authorization:deleteRole',
});
}
methodDeprecationLogger.deprecatedParameterUsage(
'authorization:deleteRole',
'role',
'7.0.0',
({ parameter, method, version }) => `Calling ${method} with ${parameter} names is deprecated and will be removed ${version}`,
);
}
if (role.protected) {
throw new Meteor.Error('error-delete-protected-role', 'Cannot delete a protected role', {
method: 'authorization:deleteRole',
});
}
const users = await Roles.countUsersInRole(role._id);
if (users > 0) {
throw new Meteor.Error('error-role-in-use', "Cannot delete role because it's in use", {
method: 'authorization:deleteRole',
});
}
return Roles.removeById(role._id);
},
});