Mirrors/Rocket.Chat
1
0
Fork 0
mirror of https://github.com/RocketChat/Rocket.Chat.git synced 2025-12-28 06:47:25 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix: Export Messages tab closing due to "flex-tab close when click outside of it" preference (#36812)

Browse Source 
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
This commit is contained in:
Tiago Evangelista Pinto 2025-09-01 20:38:38 -03:00 committed by GitHub
parent 37bb227dd1
commit 5010b3685a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/fluffy-dryers-obey.md Normal file
View File

@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---
Prevent `Export Messages` tab from closing when selecting messages by clicking outside of it and preference "Hide Contextual Bar by clicking outside of it" is set true.

14
apps/meteor/client/views/room/MessageList/contexts/SelectedMessagesContext.tsx
View File

@ -1,3 +1,4 @@
import type { FormEvent } from 'react';
import { createContext, useCallback, useContext, useEffect, useSyncExternalStore } from 'react';
import { selectedMessageStore } from '../../providers/SelectedMessagesProvider';
@ -48,11 +49,16 @@ export const useIsSelecting = (): boolean => {
return useSyncExternalStore(subscribe, getSnapshot);
};
export const useToggleSelect = (mid: string): (() => void) => {
export const useToggleSelect = (mid: string): ((event?: FormEvent<HTMLElement>) => void) => {
const { selectedMessageStore } = useContext(SelectedMessageContext);
return useCallback(() => {
selectedMessageStore.toggle(mid);
}, [mid, selectedMessageStore]);
return useCallback(
(event) => {
event?.stopPropagation();
selectedMessageStore.toggle(mid);
},
[mid, selectedMessageStore],
);
};
export const useToggleSelectAll = (): (() => void) => {

4
apps/meteor/tests/e2e/export-messages.spec.ts
View File

@ -145,9 +145,7 @@ test.describe('export-messages', () => {
await expect(exportMessagesTab.sendButton).toBeEnabled();
});
// TODO: Fix this test - the test is failing because when selecting the message, the import messages tab becomes not visible
// and the message is not selected.
test.fail('should be able to select a single message to export with hide contextual bar preference enabled', async ({ page, api }) => {
test('should be able to select a single message to export with hide contextual bar preference enabled', async ({ page, api }) => {
await api.post('/users.setPreferences', {
userId: 'rocketchat.internal.admin.test',
data: { hideFlexTab: true },