diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b519bfd8f3c..09704ad84d7 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -32,7 +32,8 @@ Without automated tests, future regressions in the expected behavior can't be au If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually. ## Basing the PR against the correct MariaDB version - [ ] *This is a new feature and the PR is based against the latest MariaDB development branch.* @@ -43,5 +44,5 @@ Tick one of the following boxes [x] to help us understand if the base branch for Maintainers are happy to point out inconsistencies but in order to speed up the review and merge process we ask you to check the CODING standards. --> ## PR quality check -- [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/11.0/CODING_STANDARDS.md) file and my PR conforms to this where appropriate. +- [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/-/CODING_STANDARDS.md) file and my PR conforms to this where appropriate. - [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves. diff --git a/CODING_STANDARDS.md b/CODING_STANDARDS.md index 4310fb553e7..136602b37bd 100644 --- a/CODING_STANDARDS.md +++ b/CODING_STANDARDS.md @@ -37,14 +37,21 @@ The commit messages are typically rendered in [Markdown format](https://docs.git When updating your code, please make sure you perform a rebase, not a merge with the latest branch. Pull requests should be a simple fast-forward of the branch they are intended to land on. -The correct way to rebase (if working on top of 10.3 branch): +The correct way to rebase (if working on top of 10.11 branch): ```sh -git fetch upstream/10.3 # This assumes upstream is github.com/MariaDB/server -git rebase upstream/10.3 +git fetch upstream/10.11 # This assumes upstream is github.com/MariaDB/server +git rebase upstream/10.11 git push --force my_branch ``` +### Target branch + +Pull requests should be based against the correct MariaDB version. +New features should be based against the latest MariaDB development branch, which is the current GitHub default branch: https://github.com/MariaDB/server/blob/-/VERSION +Bug fixes should be based against the earliest maintained branch in which the bug can be reproduced. +The earliest maintained branch is found at https://mariadb.org/about/#maintenance-policy. + ## Coding Style (C / C++ files) Everyone has a preferred coding style, there is no real correct style for all projects around the world.