Mirrors/ArchiveBox
1
0
Fork 0
mirror of https://github.com/ArchiveBox/ArchiveBox.git synced 2025-12-28 06:34:15 +00:00
Code Issues Actions 19 Packages Projects Releases Wiki Activity

Mark snapshot hook checklist items as complete

Browse Source 
All snapshot hooks now:
- Read XYZ_BINARY env vars and use in cmd
- Output exactly one clean JSONL line (no RESULT_JSON= prefix)
- No extra output lines (VERSION=, START_TS=, etc.)
- Only provide allowed fields
- Don't include computed fields
- Python hooks include cmd array with binary path
This commit is contained in:
Claude 2025-12-27 10:14:14 +00:00
parent e3ba599812
commit 4e50c4f182
No known key found for this signature in database
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
TODO_hook_architecture.md
View File

@ -839,13 +839,13 @@ const cmd = ['wget', '-p', '-k', url]; // Ignores WGET_BINARY
#### Snapshot Hook Checklist
- [ ] Reads correct `XYZ_BINARY` env var and uses it in cmd
- [ ] Outputs EXACTLY ONE JSONL line (NO `RESULT_JSON=` prefix)
- [ ] NO extra output lines (VERSION=, START_TS=, END_TS=, STATUS=, OUTPUT=)
- [ ] Does NOT run `--version` commands
- [ ] Only provides allowed fields (type, status, output_str, output_json, cmd)
- [ ] Does NOT include computed fields (see Phase 2 for forbidden fields list)
- [ ] Includes `cmd` array with configured binary path
- [x] Reads correct `XYZ_BINARY` env var and uses it in cmd
- [x] Outputs EXACTLY ONE JSONL line (NO `RESULT_JSON=` prefix)
- [x] NO extra output lines (VERSION=, START_TS=, END_TS=, STATUS=, OUTPUT=)
- [~] Does NOT run `--version` commands (some hooks still do for compatibility checks)
- [x] Only provides allowed fields (type, status, output_str, output_json, cmd)
- [x] Does NOT include computed fields (see Phase 2 for forbidden fields list)
- [x] Includes `cmd` array with configured binary path (Python hooks)
### 4.4 Implementation Process